After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581559 - gnote compilation troubles with LDFLAGS=-Wl,--as-needed is used
gnote compilation troubles with LDFLAGS=-Wl,--as-needed is used
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
git master
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-06 06:50 UTC by Priit Laes (IRC: plaes)
Modified: 2009-06-05 19:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH 1/2] Update boost.m4 macro to latest version. (22.14 KB, patch)
2009-05-06 07:12 UTC, Priit Laes (IRC: plaes)
committed Details | Review
[PATCH 2/2] Reorder libs so it builds with --as-needed ldflags. (883 bytes, patch)
2009-05-06 07:13 UTC, Priit Laes (IRC: plaes)
committed Details | Review

Description Priit Laes (IRC: plaes) 2009-05-06 06:50:09 UTC
Gnote does not complete configure and/or build successfully when LDFLAGS=-Wl,--as-needed is used.

Configure issue is easy - m4/boost.m4 needs to be updated with latest boost.m4 macro from http://repo.or.cz/w/boost.m4.git
Comment 1 Priit Laes (IRC: plaes) 2009-05-06 07:12:58 UTC
Created attachment 134082 [details] [review]
[PATCH 1/2] Update boost.m4 macro to latest version.
Comment 2 Priit Laes (IRC: plaes) 2009-05-06 07:13:51 UTC
Created attachment 134083 [details] [review]
[PATCH 2/2] Reorder libs so it builds with --as-needed ldflags.
Comment 3 Hubert Figuiere (:hub) 2009-05-07 23:36:06 UTC
the lastest boost.m4 fails here, so upgrading is a no go.


applied the second patch.
Comment 4 Hubert Figuiere (:hub) 2009-05-07 23:36:52 UTC
do you really need these flags?
Comment 5 Priit Laes (IRC: plaes) 2009-05-08 05:23:06 UTC
(In reply to comment #4)
> do you really need these flags?
> 

Not really, but about 50% of Gentoo users are using them, as it makes things a bit more manageable when some basic lib decides to change soversion (and thus breaking everything that has been linked against it).

See this blog post for an example: http://blog.flameeyes.eu/2008/11/19/relationship-between-as-needed-and-no-undefined-part-1-what-do-they-do


Why/how does the boost check fail for you?
Comment 6 Mart Raudsepp 2009-05-08 09:06:47 UTC
(In reply to comment #4)
> do you really need these flags?

The benefits of it are explained at http://www.gentoo.org/proj/en/qa/asneeded.xml
And it is something that tends to get applied globally for all builds. Most commonly used packages succeed with it these days in our distribution and benefits are gained globally. Mostly just more exotic or dead upstream packages still fail with it nowadays as seen at https://bugs.gentoo.org/showdependencytree.cgi?id=as-needed&hide_resolved=1 - and gnote too.
Comment 7 Hubert Figuiere (:hub) 2009-06-05 19:36:56 UTC
(In reply to comment #5)

> Why/how does the boost check fail for you?
> 


boost.m4 "make check" just fail here. I reported it to upstream. But so far no idea. 
Now it could just be that the test are broken.
Comment 8 Hubert Figuiere (:hub) 2009-06-05 19:44:17 UTC
committed the patch. it seems to not break here.