After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581141 - Clean up underscores in function and variable names
Clean up underscores in function and variable names
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-02 22:37 UTC by Owen Taylor
Modified: 2009-05-04 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Clean up underscores in function and variable names (10.21 KB, patch)
2009-05-02 22:37 UTC, Owen Taylor 		accepted-commit_now Details | Review

Description Owen Taylor 2009-05-02 22:37:44 UTC 
Try to fix all places where we accidentally used foo_bar instead
of fooBar for function names, function parameters, and variables.

(Lucas Rocha pointed out one example.)
Comment 1 Owen Taylor 2009-05-02 22:37:47 UTC 
Created attachment 133832 [details] [review]
Clean up underscores in function and variable names
Comment 2 Dan Winship 2009-05-02 23:45:57 UTC 
Meh. It would be a lot nicer if gjs translated the gir APIs to use camelcase too. I feel silly typing "this.scaleX = that.scale_x;"

This will probably break again when we're not looking. pre-commit hook? :)
Comment 3 Owen Taylor 2009-05-03 00:04:56 UTC 
At least as I read the code in gjs, you can actually use camel-case for properties and write

 this.scaleX = that.scaleX;

But then you have inconsistencies with methods...
Comment 4 Owen Taylor 2009-05-04 17:53:16 UTC 
Applied, without worrying about possibly changing how we do properties; we can do that at some other point if we decide we want to do it.