After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581137 - run dialog can't handle command-line options
run dialog can't handle command-line options
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-02 21:24 UTC by Jonathan Blandford
Modified: 2009-08-18 22:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Let the run dialog accept command options (1006 bytes, patch)
2009-07-14 10:59 UTC, Sander Dijkhuis 		needs-work Details | Review
Use g_shell_parse_argv() in run dialog (1.27 KB, patch)
2009-08-10 19:50 UTC, Dan Winship 		accepted-commit_now Details | Review

Description Jonathan Blandford 2009-05-02 21:24:52 UTC 
The run dialog doesn't handle options.  For example, typing "xterm" starts xterm as expecterm, but "xterm -rv" doesn't work and outputs:

      JS LOG: Could not run command xterm -rv.
Comment 1 Sander Dijkhuis 2009-07-14 10:59:38 UTC 
Created attachment 138389 [details] [review]
Let the run dialog accept command options

This patch should fix the issue.
Comment 2 Dan Winship 2009-07-14 11:55:25 UTC 
It would be better to use g_shell_parse_argv() (so that spaces in the command line can be quoted or escaped). It looks like it's currently not introspected quite right (argvp isn't marked "out"), but that could be fixed with some annotating.
Comment 3 Dan Winship 2009-08-10 19:50:11 UTC 
Created attachment 140367 [details] [review]
Use g_shell_parse_argv() in run dialog
Comment 4 Owen Taylor 2009-08-18 21:26:37 UTC 
Comment on attachment 140367 [details] [review]
Use g_shell_parse_argv() in run dialog

Looks good, please up version requirement on gobject-introspection to 0.6.4 when committing, since it looks like you are depending on a newly added annotation.