After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580956 - Missing 24x24 icon
Missing 24x24 icon
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: general
GIT master
Other Linux
: Normal trivial
: ---
Assigned To: Ekiga maintainers
Ekiga maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-30 23:26 UTC by Robert Ancell
Modified: 2010-11-22 10:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
Installs 24x24 icon (928 bytes, patch)
2009-04-30 23:28 UTC, Robert Ancell
committed Details | Review
24x24 icon for ekiga (1.40 KB, image/png)
2009-04-30 23:30 UTC, Robert Ancell
  Details

Description Robert Ancell 2009-04-30 23:26:06 UTC
Ekiga is missing a 24x24 icon which is required by the GNOME menu.  This causes the menu to display a fuzzy scaled down 32x32 icon.

Ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/ekiga/+bug/350683
Comment 1 Robert Ancell 2009-04-30 23:28:18 UTC
Created attachment 133708 [details] [review]
Installs 24x24 icon
Comment 2 Robert Ancell 2009-04-30 23:30:06 UTC
Created attachment 133710 [details]
24x24 icon for ekiga

Generated by adding a border as suggested in http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines
Install in pixmaps/24x24/apps
Comment 3 Eugen Dedu 2009-05-01 09:04:14 UTC
I see in http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines:
1. "The toolbar size of 24×24 pixels is not used in Tango themes; it's 22×22 pixels instead."
2. Also, the 24x24 should be taken from 48x48.
Comment 4 Robert Ancell 2009-05-02 07:50:10 UTC
The section that I'm reading is:

"Historically Gnome uses 24×24 size (which is ¼ of 48×48); just adding a 1 pixel empty space on all sides can make Tango icons useful on the Gnome desktop in the transition phase. One can easily do this with imagemagick:

convert -bordercolor Transparent -border 1x1 tango_size.png gnome_size.png"

We appear to still be in the "transition phase" as the menu still requests 24x24 icons.

I think the meaning of the the line mentioned in 1. is don't produce an icon at 24x24 - produce it at 22x22 and add a 1 pixel border if necessary.
Comment 5 Andreas Nilsson 2010-11-02 00:51:46 UTC
We should do both 22x22 and 24x24.
22x22 is for running under KDE, 24x24 is what our GNOME menus expect. Using 48x48 and scaling it down will just cause blur.
So +1 for Roberts patch!
Comment 6 Eugen Dedu 2010-11-18 11:45:56 UTC
This is related to bug #575611.
Comment 7 Robert Ancell 2010-11-19 00:04:15 UTC
Euden, I don't see the connection.

Bug #575611 is about the Ekiga forcing a 24x24 icon into the toolbar regardless of how large the toolbar has been configured to use.

This bug is about the panel requesting a 24x24 icon (which is how it is configured by default) but having to scale an icon of a different size because one does not exist.

This is a very minor patch to stop the menu from being blurry (which it is currently on default GNOME systems).  If we spend any more time discussing it the menu will have moved on to a different icon size.
Comment 8 Eugen Dedu 2010-11-20 18:15:10 UTC
(In reply to comment #7)
> This is a very minor patch to stop the menu from being blurry (which it is
> currently on default GNOME systems).  If we spend any more time discussing it
> the menu will have moved on to a different icon size.

You're right.  Is committing the two patches in this bug report sufficient to close this bug?
Comment 9 Robert Ancell 2010-11-22 09:57:01 UTC
Thanks Eugen, I've committed the two patches.
Comment 10 Eugen Dedu 2010-11-22 10:28:54 UTC
Thanks to you and sorry for taking so long!  (Note: first line in a commit log should be short :o))