GNOME Bugzilla – Bug 580904
Kill libgnome(ui) dependency
Last modified: 2009-08-24 10:41:16 UTC
No idea if evo-mapi will have feature parity with e-e for 2.29. In case it won't have, please fix: http://live.gnome.org/LibgnomeMustDie $:andre\> grep -r "include <libgnome" . ./storage/migr-test.c:#include <libgnomeui/gnome-app.h> ./storage/migr-test.c:#include <libgnomeui/gnome-ui-init.h> ./storage/migr-test.c:#include <libgnome/libgnome.h> ./storage/ximian-connector-setup.c:#include <libgnomeui/gnome-ui-init.h> ./storage/main.c:#include <libgnomeui/gnome-ui-init.h> ./storage/exchange-autoconfig-wizard.c:#include <libgnomeui/gnome-druid.h> ./storage/exchange-autoconfig-wizard.c:#include <libgnomeui/gnome-druid-page-standard.h> Also see bug 580887 for evolution and its subbugs. PS: e-e is missing version 2.26 in this bugzilla. Please create.
GnomeDruid will be fun. The rest should be easy.
Created attachment 138672 [details] [review] Looks like two headers are not needed anyway
Heja abharath! Asking for a quick review and test of the patch here. Cleans up our GNOME3 readiness statistics a bit... Do you plan to work on the rest of the issues soon? Except for GnomeDruid this should be easy...
Reviewed and tested. Unused pieces. And yes I'll look at the rest of the issues but as mentioned no GnomeDruid :) More than the issues, its Matthew's scare in comment #1 that keeps me away from it ;)
Committed: 21950d46ca668d5039a5453e29d67b9a90a7e72f
Oh don't mind me. There's even a tutorial to walk you through it: http://library.gnome.org/devel/gtk/stable/gtk-migrating-GtkAssistant.html
========== WORK LEFT: ========== ./storage/migr-test.c:#include <libgnomeui/gnome-ui-init.h> ./storage/ximian-connector-setup.c:#include <libgnomeui/gnome-ui-init.h> ./storage/main.c:#include <libgnomeui/gnome-ui-init.h> ./storage/exchange-autoconfig-wizard.c:#include <libgnomeui/gnome-druid.h> ./storage/exchange-autoconfig-wizard.c:#include <libgnomeui/gnome-druid-page-standard.h> The first three issues should be really simple to fix. And if abharath fixes the last two ones too we have somebody with enough knowledge to also remove gnome-druid from evolution. ;-)
Created attachment 141144 [details] [review] proposed eex patch for evolution-exchange; It is not possible to leave the actual page after clicking Forward, thus this brings the failure page instead of an error dialog. This is for exchange-connector-setup process. I wasn't able to test it full, as mine test server is down at the moment. The rest changes should work fine, I hope.
Awesome. Patch looks good to commit. Thanks for fixing this up.
Patch seems to be doing good .. i haven't seen any regression in half an hr run.
With Akhil's little bit more testing we found that the assistant_apply_cb may not contain the gtk_widget_destroy, it's handled in the close signal. Thus removed that. Otherwise patch kept as is. Enjoy. Created commit a0ba3a0 in eex master (2.29.1+)
Please could you mark for translation the following string: + w = gtk_check_button_new_with_label ("Make this my default account");
Also, is there a reason that string does not have a mnemonic?
(In reply to comment #12) > Please could you mark for translation the following string: > > + w = gtk_check_button_new_with_label ("Make this my default account"); Sure, thanks for the review. Created commit 8887a74 in eex master (2.29.1+) (In reply to comment #13) > Also, is there a reason that string does not have a mnemonic? I do not know, I kept it as it was.
Filed bug 592875.