GNOME Bugzilla – Bug 580616
gnome-settings-daemon doesn't reliably detect keybinding changes
Last modified: 2009-06-15 05:58:09 UTC
This has been reported here: https://bugzilla.redhat.com/show_bug.cgi?id=497725 Sometimes when reassigning one of the XF86Audio keys to a custom keybinding, the new binding doesn't work (ie the custom command is not triggered). And I've also seen situations where after reassigning the key back to its standard function, both the custom command and the volume popup were triggered. When that happened, I looked at gconf, and the binding entry for the custom binding had correctly been reset to empty, but the command was still triggered. Therefore, I assume the plugin that handles the keybindings got out of sync with whats in gconf somehow.
Created attachment 133592 [details] [review] patch Here is a patch that fixes this for me. Need to be more careful when comparing two key structs. With the current code, whenever one of them had keycodes == NULL, they were considered the same. Which is exactly what happens when creating a new custom binding, or removing one.
The usual indentation issues aside (plus opening braces should be same line as the "else"), please apply.