After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580525 - Patch to add CreateNamedNoteWithGuid to dbus RemoteControl
Patch to add CreateNamedNoteWithGuid to dbus RemoteControl
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
0.14.x
Other All
: Normal enhancement
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
: 591906 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-04-27 23:24 UTC by mattjones
Modified: 2009-11-15 23:46 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
patch mentioned in bug (1.93 KB, patch)
2009-04-27 23:26 UTC, mattjones 		none Details | Review
Better patch for CreateNamedNoteWithUri (1.96 KB, patch)
2009-04-28 01:37 UTC, mattjones 		none Details | Review
for new trunk, less white space, and another try-catch. (1.68 KB, patch)
2009-11-15 22:31 UTC, mattjones 		needs-work Details | Review
String.IsNullOrEmpty check on guid (1.77 KB, patch)
2009-11-15 22:55 UTC, mattjones 		committed Details | Review

Description mattjones 2009-04-27 23:24:43 UTC 
I've written a patch to make it so you can create a new note, while specifying the name and guid the note will have.
Comment 1 mattjones 2009-04-27 23:26:41 UTC 
Created attachment 133461 [details] [review]
patch mentioned in bug

The CreateNamedNoteWithGuid method will return "" if there is another note that has the same title or guid.
Comment 2 mattjones 2009-04-28 01:37:09 UTC 
Created attachment 133466 [details] [review]
Better patch for CreateNamedNoteWithUri

I was looking at the tomboy source more. It looks like the dbus methods all prefer to use URIs rather than Guids or Uuids. So this is a new patch to use Uris rather than Guids.

Sorry about patch duping. This one is better.
Comment 3 Sandy Armstrong 2009-11-15 22:01:55 UTC 
*** Bug 591906 has been marked as a duplicate of this bug. ***
Comment 4 mattjones 2009-11-15 22:31:24 UTC 
Created attachment 147826 [details] [review]
for new trunk, less white space, and another try-catch.
Comment 5 Sandy Armstrong 2009-11-15 22:36:58 UTC 
Review of attachment 147826 [details] [review]:

One minor change, then this is good to go.

::: Tomboy/RemoteControl.cs
@@ +126,3 @@
+		Note note;
+	{
+	public string CreateNamedNoteWithUri (string linked_title, string uri)

I'd like to see a String.IsNullOrEmpty check on guid before proceeding to the next step.
Comment 6 mattjones 2009-11-15 22:55:15 UTC 
Created attachment 147827 [details] [review]
String.IsNullOrEmpty check on guid
Comment 7 Sandy Armstrong 2009-11-15 23:19:44 UTC 
Thanks for your patience, pushed to master.
Comment 8 mattjones 2009-11-15 23:46:43 UTC 
Excellent. Thankyou, Thankyou, Thankyou!