GNOME Bugzilla – Bug 580329
Use show_uri() to display help window
Last modified: 2009-05-01 14:30:41 UTC
As per http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp Replace use of gnome.help_display_with_doc_id() by gtk.show_uri() Here is a patch that does the requested migration. Please review. Comments appreciated.
Created attachment 133361 [details] [review] use show_uri()
Many thanks! Committed to master and gnome-2-26.
I think you should change the author filed when committing someone else's work, so that attribution is properly kept. If I recall correctly you can do this by adding a "From:" line to the commit message metadata. But thanks anyways to have taken care of it.
(In reply to comment #3) > I think you should change the author filed when committing someone else's work, > so that attribution is properly kept. Crap. Sorry about that. With SVN, I was very religious about providing proper attribution. I'm still getting used to the 'conveniences' provided by GIT and haven't yet learned all the hoops I need to jump through. :-) I make sure it ends up in the ChangeLog, though.
BTW, I *think* the git format-patch operation should create a patch you can attach that I can apply with git am. If done this way, the patch provider essentially ensures proper attribution as I understand it.
Yes I think you're right about git format-patch, I didn't use it since I didn't commit the patch in my cloned repository yet. And I also intended to commit it myself and create a proper changelog at that time... Case closed, no harm done, that was a small patch anyways.