Bug 580301 – network: a few issues on old darwin

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 580301 - network: a few issues on old darwin


Summary:	network: a few issues on old darwin


Status:	RESOLVED OBSOLETE

Product:	glib
Classification:	Platform
Component:	network
Version:	unspecified
Hardware:	Other Mac OS

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gtkdev
QA Contact:	gtkdev

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-04-26 15:05 UTC by paul
Modified:	2012-07-12 08:42 UTC

See Also:
GNOME target:	---
GNOME version:	2.29/2.30

Attachments
gawky patch (4.55 KB, patch) 2009-04-26 15:06 UTC, paul	rejected	Details \| Review
Fix the networking stuff on (current) OS X. (1.14 KB, patch) 2009-04-26 16:20 UTC, Dan Winship	committed	Details \| Review
another largely uncommitable patch posted only for closure (1.76 KB, patch) 2009-04-26 18:21 UTC, paul	none	Details \| Review
nameser.h (13.29 KB, text/plain) 2009-04-26 20:14 UTC, paul		Details
nameser_compat.h (6.49 KB, text/plain) 2009-04-26 20:17 UTC, paul		Details
Fix gresolver build under OS X 10.2 (2.12 KB, patch) 2009-04-27 21:37 UTC, Dan Winship	none	Details \| Review

Description paul 2009-04-26 15:05:11 UTC

libasyncns/asyncns.c really didn't like not having HAVE_PTHREAD defined, arpa/nameser_compat.h caused more problems than solutions, added sys/time.h for tv
gio/ginetaddress.c added string.h for memcpy warning, and some other stuff googling said solved the problem
gio/gnetworkingprivate.h added define for T_SRV as unfortunately, i don't have it defined and halted a few things
gio/gunixresolver.c added netinet/in.h and arpa/nameser.h to quit resolv.h from gumming things up

Making all in libasyncns
/usr/bin/glibtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I/Source/glib/glib/gio/libasyncns -I../.. -I/Source/glib/glib  -I/opt/local/include -I/usr/X11R6/include            -arch ppc  -g -Wall -Wno-long-double   -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3   -MT asyncns.lo -MD -MP -MF .deps/asyncns.Tpo -c -o asyncns.lo /Source/glib/glib/gio/libasyncns/asyncns.c
 gcc -DHAVE_CONFIG_H -I. -I/Source/glib/glib/gio/libasyncns -I../.. -I/Source/glib/glib -I/opt/local/include -I/usr/X11R6/include -arch ppc -g -Wall -Wno-long-double -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3 -MT asyncns.lo -MD -MP -MF .deps/asyncns.Tpo -c /Source/glib/glib/gio/libasyncns/asyncns.c  -fno-common -DPIC -o .libs/asyncns.o
In file included from /Source/glib/glib/gio/libasyncns/asyncns.c:45:
/usr/include/arpa/nameser_compat.h:99: error: conflicting types for `HEADER'
/usr/include/arpa/nameser.h:304: error: previous declaration of `HEADER'
/Source/glib/glib/gio/libasyncns/asyncns.c: In function `close_allv':
/Source/glib/glib/gio/libasyncns/asyncns.c:206: error: storage size of `rl' isn't known
/Source/glib/glib/gio/libasyncns/asyncns.c:277: warning: implicit declaration of function `getrlimit'
/Source/glib/glib/gio/libasyncns/asyncns.c:277: error: `RLIMIT_NOFILE' undeclared (first use in this function)
/Source/glib/glib/gio/libasyncns/asyncns.c:277: error: (Each undeclared identifier is reported only once
/Source/glib/glib/gio/libasyncns/asyncns.c:277: error: for each function it appears in.)
/Source/glib/glib/gio/libasyncns/asyncns.c:206: warning: unused variable `rl'
/Source/glib/glib/gio/libasyncns/asyncns.c: In function `serialize_addrinfo':
/Source/glib/glib/gio/libasyncns/asyncns.c:417: error: `uint8_t' undeclared (first use in this function)
/Source/glib/glib/gio/libasyncns/asyncns.c:417: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c:418: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c:424: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c: In function `send_nameinfo_reply':
/Source/glib/glib/gio/libasyncns/asyncns.c:482: error: `uint8_t' undeclared (first use in this function)
/Source/glib/glib/gio/libasyncns/asyncns.c:482: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c:482: warning: left-hand operand of comma expression has no effect
/Source/glib/glib/gio/libasyncns/asyncns.c:482: warning: left-hand operand of comma expression has no effect
/Source/glib/glib/gio/libasyncns/asyncns.c:482: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c:485: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c:485: warning: left-hand operand of comma expression has no effect
/Source/glib/glib/gio/libasyncns/asyncns.c:485: warning: left-hand operand of comma expression has no effect
/Source/glib/glib/gio/libasyncns/asyncns.c:485: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c: In function `send_res_reply':
/Source/glib/glib/gio/libasyncns/asyncns.c:507: error: `uint8_t' undeclared (first use in this function)
/Source/glib/glib/gio/libasyncns/asyncns.c:507: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c:507: warning: left-hand operand of comma expression has no effect
/Source/glib/glib/gio/libasyncns/asyncns.c:507: warning: left-hand operand of comma expression has no effect
/Source/glib/glib/gio/libasyncns/asyncns.c:507: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c: In function `handle_request':
/Source/glib/glib/gio/libasyncns/asyncns.c:554: error: parse error before "uint8_t"
/Source/glib/glib/gio/libasyncns/asyncns.c: In function `process_worker':
/Source/glib/glib/gio/libasyncns/asyncns.c:675: error: variable `tv' has initializer but incomplete type
/Source/glib/glib/gio/libasyncns/asyncns.c:675: warning: excess elements in struct initializer
/Source/glib/glib/gio/libasyncns/asyncns.c:675: warning: (near initialization for `tv')
/Source/glib/glib/gio/libasyncns/asyncns.c:675: warning: excess elements in struct initializer
/Source/glib/glib/gio/libasyncns/asyncns.c:675: warning: (near initialization for `tv')
/Source/glib/glib/gio/libasyncns/asyncns.c:675: error: storage size of `tv' isn't known
/Source/glib/glib/gio/libasyncns/asyncns.c:675: warning: unused variable `tv'
/Source/glib/glib/gio/libasyncns/asyncns.c: In function `unserialize_addrinfo':
/Source/glib/glib/gio/libasyncns/asyncns.c:941: error: `uint8_t' undeclared (first use in this function)
/Source/glib/glib/gio/libasyncns/asyncns.c:941: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c:941: warning: left-hand operand of comma expression has no effect
/Source/glib/glib/gio/libasyncns/asyncns.c:941: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c:944: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c:944: warning: left-hand operand of comma expression has no effect
/Source/glib/glib/gio/libasyncns/asyncns.c:944: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c:949: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c: In function `handle_response':
/Source/glib/glib/gio/libasyncns/asyncns.c:988: error: `uint8_t' undeclared (first use in this function)
/Source/glib/glib/gio/libasyncns/asyncns.c:988: error: parse error before ')' token
/Source/glib/glib/gio/libasyncns/asyncns.c: In function `_g_asyncns_getnameinfo':
/Source/glib/glib/gio/libasyncns/asyncns.c:1257: error: `uint8_t' undeclared (first use in this function)
/Source/glib/glib/gio/libasyncns/asyncns.c:1257: error: parse error before ')' token
make[5]: *** [asyncns.lo] Error 1

Making all in .
/usr/bin/glibtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I/Source/glib/glib/gio -I..  -DG_LOG_DOMAIN=\"GLib-GIO\" -I.. -I/Source/glib/glib -I/Source/glib/glib/glib -I/Source/glib/glib/gmodule -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED -DGIO_COMPILATION -DGIO_MODULE_DIR=\"/opt/local/lib/gio/modules\"  -I/opt/local/include -I/usr/X11R6/include            -arch ppc  -g -Wall -Wno-long-double   -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3   -MT ginetaddress.lo -MD -MP -MF .deps/ginetaddress.Tpo -c -o ginetaddress.lo /Source/glib/glib/gio/ginetaddress.c
 gcc -DHAVE_CONFIG_H -I. -I/Source/glib/glib/gio -I.. -DG_LOG_DOMAIN=\"GLib-GIO\" -I.. -I/Source/glib/glib -I/Source/glib/glib/glib -I/Source/glib/glib/gmodule -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED -DGIO_COMPILATION -DGIO_MODULE_DIR=\"/opt/local/lib/gio/modules\" -I/opt/local/include -I/usr/X11R6/include -arch ppc -g -Wall -Wno-long-double -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3 -MT ginetaddress.lo -MD -MP -MF .deps/ginetaddress.Tpo -c /Source/glib/glib/gio/ginetaddress.c  -fno-common -DPIC -o .libs/ginetaddress.o
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_set_property':
/Source/glib/glib/gio/ginetaddress.c:114: warning: implicit declaration of function `memcpy'
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_get_is_any':
/Source/glib/glib/gio/ginetaddress.c:533: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:533: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:533: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:533: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_get_is_loopback':
/Source/glib/glib/gio/ginetaddress.c:559: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:559: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:559: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:559: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_get_is_link_local':
/Source/glib/glib/gio/ginetaddress.c:587: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:587: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_get_is_site_local':
/Source/glib/glib/gio/ginetaddress.c:618: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:618: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_get_is_multicast':
/Source/glib/glib/gio/ginetaddress.c:643: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_get_is_mc_global':
/Source/glib/glib/gio/ginetaddress.c:664: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:664: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_get_is_mc_link_local':
/Source/glib/glib/gio/ginetaddress.c:685: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:685: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_get_is_mc_node_local':
/Source/glib/glib/gio/ginetaddress.c:706: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:706: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_get_is_mc_org_local':
/Source/glib/glib/gio/ginetaddress.c:727: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:727: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c: In function `g_inet_address_get_is_mc_site_local':
/Source/glib/glib/gio/ginetaddress.c:748: error: request for member `__u6_addr' in something not a structure or union
/Source/glib/glib/gio/ginetaddress.c:748: error: request for member `__u6_addr' in something not a structure or union
make[5]: *** [ginetaddress.lo] Error 1
/usr/bin/glibtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I/Source/glib/glib/gio -I..  -DG_LOG_DOMAIN=\"GLib-GIO\" -I.. -I/Source/glib/glib -I/Source/glib/glib/glib -I/Source/glib/glib/gmodule -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED -DGIO_COMPILATION -DGIO_MODULE_DIR=\"/opt/local/lib/gio/modules\"  -I/opt/local/include -I/usr/X11R6/include            -arch ppc  -g -Wall -Wno-long-double   -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3   -MT gresolver.lo -MD -MP -MF .deps/gresolver.Tpo -c -o gresolver.lo /Source/glib/glib/gio/gresolver.c
 gcc -DHAVE_CONFIG_H -I. -I/Source/glib/glib/gio -I.. -DG_LOG_DOMAIN=\"GLib-GIO\" -I.. -I/Source/glib/glib -I/Source/glib/glib/glib -I/Source/glib/glib/gmodule -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED -DGIO_COMPILATION -DGIO_MODULE_DIR=\"/opt/local/lib/gio/modules\" -I/opt/local/include -I/usr/X11R6/include -arch ppc -g -Wall -Wno-long-double -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3 -MT gresolver.lo -MD -MP -MF .deps/gresolver.Tpo -c /Source/glib/glib/gio/gresolver.c  -fno-common -DPIC -o .libs/gresolver.o
/Source/glib/glib/gio/gresolver.c: In function `_g_resolver_targets_from_res_query':
/Source/glib/glib/gio/gresolver.c:794: error: `T_SRV' undeclared (first use in this function)
/Source/glib/glib/gio/gresolver.c:794: error: (Each undeclared identifier is reported only once
/Source/glib/glib/gio/gresolver.c:794: error: for each function it appears in.)
make[5]: *** [gresolver.lo] Error 1
/usr/bin/glibtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I/Source/glib/glib/gio -I..  -DG_LOG_DOMAIN=\"GLib-GIO\" -I.. -I/Source/glib/glib -I/Source/glib/glib/glib -I/Source/glib/glib/gmodule -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED -DGIO_COMPILATION -DGIO_MODULE_DIR=\"/opt/local/lib/gio/modules\"  -I/opt/local/include -I/usr/X11R6/include            -arch ppc  -g -Wall -Wno-long-double   -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3   -MT gthreadedresolver.lo -MD -MP -MF .deps/gthreadedresolver.Tpo -c -o gthreadedresolver.lo /Source/glib/glib/gio/gthreadedresolver.c
 gcc -DHAVE_CONFIG_H -I. -I/Source/glib/glib/gio -I.. -DG_LOG_DOMAIN=\"GLib-GIO\" -I.. -I/Source/glib/glib -I/Source/glib/glib/glib -I/Source/glib/glib/gmodule -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED -DGIO_COMPILATION -DGIO_MODULE_DIR=\"/opt/local/lib/gio/modules\" -I/opt/local/include -I/usr/X11R6/include -arch ppc -g -Wall -Wno-long-double -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3 -MT gthreadedresolver.lo -MD -MP -MF .deps/gthreadedresolver.Tpo -c /Source/glib/glib/gio/gthreadedresolver.c  -fno-common -DPIC -o .libs/gthreadedresolver.o
/Source/glib/glib/gio/gthreadedresolver.c: In function `do_lookup_service':
/Source/glib/glib/gio/gthreadedresolver.c:527: error: `T_SRV' undeclared (first use in this function)
/Source/glib/glib/gio/gthreadedresolver.c:527: error: (Each undeclared identifier is reported only once
/Source/glib/glib/gio/gthreadedresolver.c:527: error: for each function it appears in.)
make[5]: *** [gthreadedresolver.lo] Error 1
/usr/bin/glibtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I/Source/glib/glib/gio -I..  -DG_LOG_DOMAIN=\"GLib-GIO\" -I.. -I/Source/glib/glib -I/Source/glib/glib/glib -I/Source/glib/glib/gmodule -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED -DGIO_COMPILATION -DGIO_MODULE_DIR=\"/opt/local/lib/gio/modules\"  -I/opt/local/include -I/usr/X11R6/include            -arch ppc  -g -Wall -Wno-long-double   -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3   -MT gunixresolver.lo -MD -MP -MF .deps/gunixresolver.Tpo -c -o gunixresolver.lo /Source/glib/glib/gio/gunixresolver.c
 gcc -DHAVE_CONFIG_H -I. -I/Source/glib/glib/gio -I.. -DG_LOG_DOMAIN=\"GLib-GIO\" -I.. -I/Source/glib/glib -I/Source/glib/glib/glib -I/Source/glib/glib/gmodule -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED -DGIO_COMPILATION -DGIO_MODULE_DIR=\"/opt/local/lib/gio/modules\" -I/opt/local/include -I/usr/X11R6/include -arch ppc -g -Wall -Wno-long-double -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3 -MT gunixresolver.lo -MD -MP -MF .deps/gunixresolver.Tpo -c /Source/glib/glib/gio/gunixresolver.c  -fno-common -DPIC -o .libs/gunixresolver.o
In file included from /Source/glib/glib/gio/gunixresolver.c:27:
/usr/include/resolv.h:134: error: field `nsaddr_list' has incomplete type
/usr/include/resolv.h:138: error: `MAXDNAME' undeclared here (not in a function)
/usr/include/resolv.h:144: error: field `addr' has incomplete type
/Source/glib/glib/gio/gunixresolver.c: In function `lookup_service_async':
/Source/glib/glib/gio/gunixresolver.c:381: error: `T_SRV' undeclared (first use in this function)
/Source/glib/glib/gio/gunixresolver.c:381: error: (Each undeclared identifier is reported only once
/Source/glib/glib/gio/gunixresolver.c:381: error: for each function it appears in.)
make[5]: *** [gunixresolver.lo] Error 1

Comment 1 paul 2009-04-26 15:06:00 UTC

Created attachment 133334 [details] [review]
gawky patch

Comment 2 Dan Winship 2009-04-26 15:55:11 UTC

(In reply to comment #0)
> libasyncns/asyncns.c really didn't like not having HAVE_PTHREAD defined

defining HAVE_PTHREAD there is entirely the wrong fix. libasyncns has two compile-time-selected modes, threaded and forking. We are intentionally using only the forking mode, so HAVE_PTHREAD *must* be unset.

> arpa/nameser_compat.h caused more problems than solutions
> gio/gnetworkingprivate.h added define for T_SRV as unfortunately, i don't have
> it defined and halted a few things

T_SRV is defined in nameser_compat.h. nameser.h and nameser_compat.h aren't supposed to conflict...

> gio/ginetaddress.c added string.h for memcpy warning, and some other stuff
> googling said solved the problem

This is bug 580194 and there's a better patch for it there.

I don't have "old darwin", but I have a current OS X box I can try this on to see if the nameser/nameser_compat and libasyncns problems show up there.

Comment 3 Dan Winship 2009-04-26 16:20:50 UTC

Created attachment 133338 [details] [review]
Fix the networking stuff on (current) OS X.

This plus the patch from bug 580194 fixes the build on current OS X.
You'll need to figure out how to fix the libasyncns build problems on your
own though.

Comment 4 Dan Winship 2009-04-26 16:24:00 UTC

it may be as simply as "#include <sys/resource.h>" ?

Comment 5 Allison Karlitskaya (desrt) 2009-04-26 16:27:40 UTC

hey dan... can you get on irc? :)

Comment 6 paul 2009-04-26 18:21:23 UTC

Created attachment 133353 [details] [review]
another largely uncommitable patch posted only for closure

(In reply to comment #2)
(In reply to comment #3)
i knew the patch was less than ideal, that's why i stated it was gawky ;)
patch in #580194 is good
and your patch in this bug works to a point

get plenty of these
In file included from /Source/glib/glib/gio/gnetworkingprivate.h:37,
                 from /Source/glib/glib/gio/gthreadedresolver.c:31:
/usr/include/arpa/nameser_compat.h:99: error: conflicting types for `HEADER'
/usr/include/arpa/nameser.h:304: error: previous declaration of `HEADER'
In file included from /Source/glib/glib/gio/gnetworkingprivate.h:49,
                 from /Source/glib/glib/gio/gthreadedresolver.c:31:
/usr/include/resolv.h:138: error: `NS_MAXDNAME' undeclared here (not in a function)
/Source/glib/glib/gio/gthreadedresolver.c: In function `do_lookup_service':
/Source/glib/glib/gio/gthreadedresolver.c:527: error: `ns_c_in' undeclared (first use in this function)
/Source/glib/glib/gio/gthreadedresolver.c:527: error: (Each undeclared identifier is reported only once
/Source/glib/glib/gio/gthreadedresolver.c:527: error: for each function it appears in.)
/Source/glib/glib/gio/gthreadedresolver.c:527: error: `ns_t_srv' undeclared (first use in this function)
make[5]: *** [gthreadedresolver.lo] Error 1

nameser.h & nameser_compat.h aren't supposed to conflict, but they do on darwin 6/macosx 10.2, i've kinda learned to live with it
i regularly use the patch from bug #162289 for this sort of problem

(In reply to comment #4)
yep
adding sys/time.h, sys/resource.h, and stdint.h (just for uint8_t) got it done

Comment 7 Dan Winship 2009-04-26 19:52:33 UTC

hm... can you attach your arpa/nameser.h and arpa/nameser_compat.h (and any relevant-looking files that they #include)?

Comment 8 paul 2009-04-26 20:14:56 UTC

Created attachment 133363 [details]
nameser.h

Comment 9 paul 2009-04-26 20:17:50 UTC

Created attachment 133364 [details]
nameser_compat.h

Comment 10 Dan Winship 2009-04-26 20:43:12 UTC

is there some other nameser-related header in arpa/ ? (ie, not nameser.h, nameser_compat.h, ftp.h, inet.h, telnet.h, or tftp.h?)

Or more specifically, your nameser_compat.h says, among other things:

    #define	T_SRV		ns_t_srv

but ns_t_srv isn't defined in either nameser.h or nameser_compat.h. So where is it defined? ("find /usr/include -type f | xargs grep ns_t_srv" ?) I think the right fix is to include arpa/nameser.h and arpa/nameser_compat.h on most systems, and whatever mystery header it is that you have, plus arpa/nameser_compat.h on your system.

Comment 11 paul 2009-04-26 21:12:51 UTC

% find /usr/include -type f | xargs grep ns_t_srv
/usr/include/arpa/nameser_compat.h:#define      T_SRV           ns_t_srv
Exit 123
there's a few things they never got around to defining on here, for anecdotal purposes, i'll point out i don't have socklen_t defined anywhere either...

Comment 12 Dan Winship 2009-04-27 21:37:47 UTC

Created attachment 133452 [details] [review]
Fix gresolver build under OS X 10.2

Can you try this (against master, with no additional patches) and tell me
if it works?

Comment 13 paul 2009-04-28 11:15:41 UTC

well, had to leave at least one patch (#381444), but your patch gets compiled smoothly

Comment 14 Dan Winship 2009-04-28 14:13:37 UTC

OK, Lennart, there are two parts of this that apply to libasyncns:

    - arpa/nameser_compat.h is broken on OS X 10.2, but it turns out that
      asyncns.c doesn't actually need to include that anyway. (Or, for
      that matter, arpa/nameser.h), so I think the upstream fix is to just
      remove those two #includes from asyncns.c.

    - OS X 10.2 needs a few extra includes (sys/time.h, sys/resource.h,
      stdint.h) in asycns.c in order to compile correctly.

Comment #12 has the patch I was going to commit, although I guess if you're going to make changes upstream, I can just copy what you do into our copies of the code now rather than waiting for the next release...

Comment 15 Lennart Poettering 2009-05-10 13:50:44 UTC

Hmm, with upstream I'll wait until someone sends me proper patches. I don't really want to write patches I cannot test.

So go ahead and integrate that patch into glib.

Comment 16 Dan Winship 2009-06-01 18:30:43 UTC

committed

Comment 17 Dan Winship 2009-06-09 13:38:05 UTC

This broke the build on current OS X (bug 584574), so I reverted it

Comment 18 Lennart Poettering 2009-10-15 01:46:34 UTC

I have now integrated those fixes into upstream libasyncns too. Currently only in git. Will do a release soon. There are also a couple of other fixes, so you might want to updated asyncns.c in the glib sources. But I guess I should open a seperate bug for that.

Comment 19 Emmanuele Bassi (:ebassi) 2012-02-29 10:31:03 UTC

should this bug be closed? is it still relevant?

Comment 20 Tobias Mueller 2012-07-12 08:42:28 UTC

I presume this is OBSOLETE as per comment #18. If it's not, please reopen.