Created attachment 133279 [details] [review]
proposed patch

Bill: Can this be reviewed?

g@gnome.org  	2009-06-23 02:30:12 UTC  	CC  	  	raywang@gnome.org 

Hoops, sorry. I mis-copy the comments and submit too quickly

> Hey, how to verify this bug? I find no way to find out glade dependency in
> configure.in before I apply the patch?

(In reply to comment #4)
> Hey, how to verify this bug? I find no way to find out glade dependency in
> configure.in before I apply the patch? 

Verify by checking how the dialogs look like?

You can not distinguish the UI is made by GtkBuilder or glade. 
If yes, How? I don't know. :(

That's what people call "testing". If you cannot distinguish: Fine.

After I configure with prefix=/usr, build up, and run /usr/bin/magnifer, I get:

(magnifier:1171): Bonobo-WARNING **: Assigning a default value to a non readable property 'source-display-screen'

(magnifier:1171): Bonobo-WARNING **: Assigning a default value to a non readable property 'target-display-screen'
** Message: added event source to xfixes cursor-notify connection
** Message: added event source to composite connection
** Message: set source bounds to 0,0; 1280,800
initial viewport 1280 800

That's all, the program is not launched?

(In reply to comment #8)
> That's all, the program is not launched?

Is that a question?
A program is launched when it can be seen on screen.

(In reply to comment #9)
> Is that a question?
> A program is launched when it can be seen on screen.
> 

heh, sorry, the program won't launch.
So do you think it is a bug? Or have you run into that problem?
I can't run it which is built from the latest commit.

(In reply to comment #10)
> heh, sorry, the program won't launch.

Ah. Now that does not have a question mark at the end of the sentence. :-)

Well, you could check whether it runs without the latest commit?

I've tried to rewind several commits, but with no luck. :(
I think it's better to have someone else verify this bug then.
I'll try it again sometime.

Current patch contains an error

ui.get.object("radio_filter_red_saturate")
should be
ui.get_object("radio_filter_red_saturate")

Please check your patch before submitting it. It now cost me several hours to find out that his was the error, because applets do not spit out anything in a terminal window :-(

Created attachment 138309 [details] [review]
Use gtkbuilder

This one works.

Can I commit?

commit ab5229314b642d3ec45237ae84f9c5798352f180
Author: Jaap A. Haitsma <jaap@haitsma.org>
Date:   Mon Jul 13 08:50:27 2009 +0200

    Use gtkbuilder instead of glade
    
    Fixes bug 580186
    Patch by Pedro Fragoso <ember@ubuntu.com>

So I assume that this is FIXED by the last comment.

At least grepping for "glade" only brings up po files.

Closing.