After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580167 - do not block settings when applying a template
do not block settings when applying a template
Status: RESOLVED OBSOLETE
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal normal
: 0.14
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks: 337894 630751
 
 
Reported: 2009-04-24 20:05 UTC by Jean-François Fortin Tam
Modified: 2010-12-10 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.56 KB, patch)
2010-09-26 04:10 UTC, Jean-François Fortin Tam 		none Details | Review

Description Jean-François Fortin Tam 2009-04-24 20:05:12 UTC 
Currently, if you apply a template, you can't change some settings such as resolution and framerate; you have to workaround by changing to "Custom" to do so. I don't really see why it has to be this way. I think a template should simply set things up, and let the user change them if he desires or if the template is incorrect.
Comment 1 Jean-François Fortin Tam 2010-09-26 04:10:08 UTC 
Created attachment 171116 [details] [review]
patch

This is a naïve attempt at fixing the problem by simply not toggling the (in)sensitive property of those widgets. 

However, I think it's slightly suboptimal, because ideally when you change the individual settings afterwards, the combobox should switch to "Custom" (by calling directly the _fillSettings method, I think?) to indicate that the user is no longer utilizing a template. I'm just not sure how to connect to signals when those widgets change, before calling _fillSettings.
Comment 2 Jean-François Fortin Tam 2010-09-26 04:24:09 UTC 
Another approach might be to make only the width and height insensitive, but make the framerate combobox widget editable at all times...