GNOME Bugzilla – Bug 580134
Displays empty bubbles for messages containing <
Last modified: 2009-08-06 13:31:06 UTC
When Rob pasted me some text from irssi, I got an empty notification bubble. This seems to be because it contained "<". I think Empathy should be escaping markup before sending it to libnotify.
Should be easy to fix, marking as gnome-love.
I don't see the problem, however ubuntu uses notify-osd, could it be a problem with the notification system?
Will, could you provide more information about your system (notification version, distro version) and does this problem still appear?
Created attachment 139908 [details] [review] Escape markup in notification bubbles. 7730ffd fixed this for the notifications that are produced by the chat window, but not for the ones produced by the status icon. Why these are separate code paths eludes me.
Whoops. My initial patch fixing this leaked the escaped strings. I've also noticed that the code which doesn't try to set a NULL pixbuf as the notification's icon still tries to unref the pixbuf, but g_object_unref (NULL); criticals. I'll fix that too...
My branch at http://git.collabora.co.uk/?p=user/wjt/empathy.git;a=shortlog;h=refs/heads/escape-notifications fixes this, and also fixes the NULL-unref I noticed. Patches to follow...
Created attachment 139910 [details] [review] Escape markup in notifications and icon tooltip 7730ffd fixed this for the notifications that are produced by the chat window, but not for the ones produced by the status icon. Why these are separate code paths eludes me.
Created attachment 139911 [details] [review] Don't try to free NULL pixbufs. It's all very well to ensure that we don't pass a NULL pixbuf to libnotify, but we shouldn't then try to g_object_unref () the pointer without checking it's not NULL.
Looks good. Please merge. Thanks for the patches!
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.