After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580033 - Don't use G_MODULE_BIND_LOCAL
Don't use G_MODULE_BIND_LOCAL
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2009-04-23 21:17 UTC by Owen Taylor
Modified: 2009-04-24 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't use G_MODULE_BIND_LOCAL (1.17 KB, patch)
2009-04-23 21:18 UTC, Owen Taylor 		none Details | Review

Description Owen Taylor 2009-04-23 21:17:53 UTC 
Using G_MODULE_BIND_LOCAL causes problems for introspecting plugins,
since introspected symbols need to be globally available. And in
any case, trying to use linker features to prevent symbol conflicts
doesn't usually work out very well, it's better to just namespace
properly.
Comment 1 Owen Taylor 2009-04-23 21:18:02 UTC 
Created attachment 133221 [details] [review]
Don't use G_MODULE_BIND_LOCAL
Comment 2 Tomas Frydrych 2009-04-24 06:57:58 UTC 
There was some reason for using G_MODULE_BIND_LOCAL; I need to do bit of digging on this one.
Comment 3 Tomas Frydrych 2009-04-24 08:10:59 UTC 
OK, whatever the reason for this was, it's gone away and everything seems to work as expected without G_MODULE_BIND_LOCAL, so please just commit it.
Comment 4 Owen Taylor 2009-04-24 13:59:35 UTC 
See:

http://bugzilla.openedhand.com/show_bug.cgi?id=1216

There was confusion when loading multiple plugins. Subsequent changes to MUTTER_PLUGIN_DECLARE() related to the switch to GTypeModule mean that it is no longer an issue, since the only symbols that are named the same in different modules are referenced with g_module_symbol().
Comment 5 Owen Taylor 2009-04-24 14:02:06 UTC 
Pushed to master on git.gnome.org. (Thanks for looking the patches over, Tomas)