After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580023 - Improve handling of errors when calling CompositeNameWindowPixmap
Improve handling of errors when calling CompositeNameWindowPixmap
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2009-04-23 20:56 UTC by Owen Taylor
Modified: 2009-04-24 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improve handling of errors when calling CompositeNameWindowPixmap (2.21 KB, patch)
2009-04-23 20:56 UTC, Owen Taylor 		none Details | Review

Description Owen Taylor 2009-04-23 20:56:28 UTC 
To guard against CompositeNameWindowPixmap failing, just use an
error trap. Previous code used:

 GrabServer/GetWindowAttributes/CompositeNameWindowPixmap/UngrabServer

To prevent BadMatch errors from !viewable, but didn't check the
return value of GetWindowAttributes and didn't check if an error
occured during the error trap. This way is more correct and more
efficient.
Comment 1 Owen Taylor 2009-04-23 20:56:33 UTC 
Created attachment 133212 [details] [review]
Improve handling of errors when calling CompositeNameWindowPixmap
Comment 2 Owen Taylor 2009-04-24 14:02:03 UTC 
Pushed to master on git.gnome.org. (Thanks for looking the patches over, Tomas)