After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579734 - [playbin] raw_decoding_mode seems to be set unconditionally
[playbin] raw_decoding_mode seems to be set unconditionally
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-21 15:46 UTC by Wim Taymans
Modified: 2009-04-21 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
possible patch (640 bytes, patch)
2009-04-21 15:47 UTC, Wim Taymans 		committed Details | Review

Description Wim Taymans 2009-04-21 15:46:25 UTC 
As found by sebp on IRC, this commit adds the raw_decoding_mode to gstplaybasebin.c:

http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=c2a56e31155cfee442fb85ed35092b07b1501f29

It seems that it always sets the raw_decoding_mode to TRUE while it should only do that it the caps are raw. The effect is that for mpeg ts streams, the queues after the demuxer fill up too quickly (due to lots of small ts packets) and since the queues after the decoder are small too, some streams are simply not detected and played.

Possible patch follows.
Comment 1 Wim Taymans 2009-04-21 15:47:24 UTC 
Created attachment 133048 [details] [review]
possible patch

Patch only sets the raw_decodinb_mode is a source pad actually has raw media.
Comment 2 Wim Taymans 2009-04-21 18:55:20 UTC 
commit 8f8b638d318858ca47ab022851f931a3116e3a79
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Tue Apr 21 20:57:34 2009 +0200

    playbin: only use raw_decoding_mode when it's true
    
    First check the pad caps if they are raw before setting the raw_decoding_mode to
    TRUE. Fixes playback of transport streams and other streams that require large
    queues.
    Fixes #579734