After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579643 - modifier keys not reset when focus change
modifier keys not reset when focus change
Status: RESOLVED FIXED
Product: meld
Classification: Other
Component: filediff
git master
Other Linux
: Normal normal
: ---
Assigned To: Vincent Legoll
Stephen Kennedy
Depends on:
Blocks:
 
 
Reported: 2009-04-20 19:20 UTC by Vincent Legoll
Modified: 2009-05-01 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix for the bug (1.95 KB, patch)
2009-04-20 19:21 UTC, Vincent Legoll 		none Details | Review
dependency of the previous patch (extract linkmap button update code) (1.62 KB, patch)
2009-04-20 19:52 UTC, Vincent Legoll 		committed Details | Review
this time without adding a backreference, just use the already present one (1.48 KB, patch)
2009-04-29 22:22 UTC, Vincent Legoll 		committed Details | Review

Description Vincent Legoll 2009-04-20 19:20:31 UTC 
if you alt tab with a modifier key pressed at the same time this modifier key stays as pressed even if released when meld had not the focus.

Steps to reproduce:
- open file diff
- press shift (see the linkmap buttons change)
- keeping shift, press alt-tab
- release shift
- refocus meld
- see the linkmap buttons still in shift mode

The debian bug report
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=470781
is about the ALT (SHIFT does that here) modifier for unsynchronized scrolling
Comment 1 Vincent Legoll 2009-04-20 19:21:10 UTC 
Created attachment 132979 [details] [review]
fix for the bug
Comment 2 Vincent Legoll 2009-04-20 19:52:09 UTC 
Created attachment 132981 [details] [review]
dependency of the previous patch (extract linkmap button update code)
Comment 3 Stephen Kennedy 2009-04-25 11:07:37 UTC 
Looks good. You don't need the melddoc variable though as there is already a back pointer to the python objects from the top level glade widget. See widget.set_data("pyobject") in gnomeglade.
Comment 4 Vincent Legoll 2009-04-29 22:22:07 UTC 
Created attachment 133614 [details] [review]
this time without adding a backreference, just use the already present one