After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579479 - Size column aligning left and not displaying fully
Size column aligning left and not displaying fully
Status: RESOLVED FIXED
Product: balsa
Classification: Other
Component: general
2.3.x
Other All
: Normal normal
: ---
Assigned To: Balsa Maintainers
Balsa Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-19 04:12 UTC by Jonathan W
Modified: 2010-03-30 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
numbers going off screen (16.21 KB, image/png)
2009-04-19 04:12 UTC, Jonathan W
Details
further demonstration of alignment issues (15.26 KB, image/png)
2009-04-19 04:14 UTC, Jonathan W
Details

Description Jonathan W 2009-04-19 04:12:04 UTC
Please describe the problem:
In message listings, the size column is not displaying the entire displayable size, because it appears to be left justifying to 4 digits—any 5th digit goes out of the column on the left and is not visible.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
screenshot available
Comment 1 Jonathan W 2009-04-19 04:12:55 UTC
Created attachment 132890 [details]
numbers going off screen
Comment 2 Jonathan W 2009-04-19 04:14:59 UTC
Created attachment 132891 [details]
further demonstration of alignment issues
Comment 3 Jack Ostroff 2010-03-24 23:12:50 UTC
This is still happening to me on 2.4.7 (Gentoo Linux).
Comment 4 Peter Bloomfield 2010-03-27 17:36:38 UTC
I see this too, and have done for a long time--possibly as long as Balsa has been using GtkTreeView for the message list.  But looking more closely, I see that it does *not* happen in the left-most mailbox (identifiable when "Show mailbox tabs" is checked).  Do you see the same?  If so, it may be a rendering bug in GtkTree*.
Comment 5 Jack Ostroff 2010-03-27 18:00:17 UTC
Well, I think you've convinced me it's a but the the rendering, but - I'm getting very inconsistent behavior!  I've just played with opening and closing mailboxes in various orders, and I cannot find any pattern.  Sometimes the Inbox opens OK, sometimes it opens showing the problem.  Sometimes the problem comes or goes on closing and reopening the mailbox.  I'll keep trying to find a pattern.

In the code, I noticed that the particular attributes and functions used is different for the different columns.  Is there any chance this is relevant - or just a red herring?
Comment 6 Peter Bloomfield 2010-03-30 12:19:37 UTC
GtkTreeView offers two ways of getting a required column width: setting the fixed width of the GtkTreeViewColumn itself, or setting the fixed size of the GtkCellRenderer packed in the column.  As Jack noted, Balsa manages some columns one way, some the other, but in particular the "Size" column has its width set to 50 pixels directly.  Occasionally it really is set to that width, but more commonly to something smaller, and like Jack I haven't found any pattern in the behavior.  I tried repeatedly opening and closing one mailbox, with no others open, and saw both behaviors.  It looks like a race when the tree-view is rendered in an idle handler; Balsa creates the tree-view in a subthread, which might be related.

Anyway, setting the width of the cell-renderer instead of the column seems to fix it.  Git master has been patched accordingly--please test if convenient.

The magic 50-pixel width is another issue--it's documented as a guess, and seems to work on my displays, but can presumably be improved upon, perhaps by offline rendering of an appropriate string...

Resolving (for now) as FIXED...