After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579422 - flacdec can block allocating before it sent a new-segment
flacdec can block allocating before it sent a new-segment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 576453 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-04-18 15:57 UTC by Thomas Vander Stichele
Modified: 2009-05-06 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Vander Stichele 2009-04-18 15:57:33 UTC 
See https://thomas.apestaart.org/thomas/trac/browser/tests/gnonlin/gnludbplay.py

This code hangs on flac files, and works on mp3/speex/ogg/...

The reason is that the first seek to 0 triggers a pad_alloc before a new segment is sent, and it blocks.
Comment 1 Thomas Vander Stichele 2009-04-18 16:28:12 UTC 
pull in the fix with:

git remote add tao http://thomas.apestaart.org/git/gstreamer/gst-plugins-good/
git fetch tao
git checkout -b bz-579422 tao/bz-579422

This fixes the test application as well as my jukebox mixer.
Comment 2 Thomas Vander Stichele 2009-04-18 16:30:14 UTC 
Marking it as a blocker so that I don't forget before the next release and other people have time to see if they agree with my approach, because it might be a hack.
Comment 3 Tim-Philipp Müller 2009-05-06 11:30:50 UTC 
If you want review before committing, maybe you could attach a patch with the fix or point us to the right commits/branch on http://cgit.freedesktop.org/~thomasvs/gst-plugins-good/ so we don't have to dig through your repo?
Comment 4 Edward Hervey 2009-05-06 12:59:18 UTC 
*** Bug 576453 has been marked as a duplicate of this bug. ***
Comment 5 Edward Hervey 2009-05-06 13:09:51 UTC 
    commit 71acf2e900877d21485d384fd01892d1dca88ea1
    Author: Thomas Vander Stichele <thomas@apestaart.org>
    Date:   Sat Apr 18 18:00:54 2009 +0200

        flacdec: don't use pad_alloc when decoding while seeking. Fixes #579422