After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579315 - Identify filter names in filtering errors
Identify filter names in filtering errors
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[filters]
Depends on:
Blocks:
 
 
Reported: 2009-04-17 16:30 UTC by Bastien Nocera
Modified: 2012-12-10 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
eds patch (1.34 KB, patch)
2012-12-10 13:45 UTC, Milan Crha
committed Details | Review
evo patch (1.02 KB, patch)
2012-12-10 13:47 UTC, Milan Crha
committed Details | Review

Description Bastien Nocera 2009-04-17 16:30:41 UTC
evolution-2.24.5-1.fc10.x86_64
evolution-data-server-2.24.5-5.fc10.x86_64

Exact same summary as bug 447977, because that's what happens.

It's probably not a duplicate of bug 444503 because I don't use Exchange.

Possible reproducer:
1) Set up a local delivery account
2) Set up an IMAP account, don't apply filter to the new messages in inbox
3) Set up a filter that moves a mail from the IMAP account to a local folder
4) Applying the filter works
5) Delete (I don't think disable actually reproduces the problem) the local delivery account
6) Try to apply the filter setup in 3

"
Error while Filtering Selected Messages.

No provider available for protocol 'email'
"

7) Go to Edit->Message filters, and edit the filter created in 3), there's no target folder selected
Comment 2 Bastien Nocera 2009-04-20 09:44:32 UTC
It certainly would, as mentioned in 7), but I don't understand why the filter would get associated with the local delivery account when it's not the one providing the storage for local mails.

What's mentioned in the FAQ is a work-around, not a fix.
Comment 3 André Klapper 2012-02-06 13:43:47 UTC
hadess: Is this still an issue, or can this be closed as OBSOLETE? Asking as I haven't seen any new bug reports about that error for a while now...
Comment 4 Bastien Nocera 2012-02-06 13:49:22 UTC
Unless positive steps have been taken to fix the problem, I'm certain the problem is still there. The reproducer steps in comment 0 should help.
Comment 5 André Klapper 2012-02-08 11:00:07 UTC
Also see bug 525932 about the error message itself.
Comment 6 Milan Crha 2012-12-04 18:45:35 UTC
This is still reproducible, with the given steps, but the message is better descriptive, due to fix from bug #525932.

Bastien, are you fine with this kind of solution?
Comment 7 Bastien Nocera 2012-12-05 11:31:26 UTC
The message is sub-par for me:
> One reason can be that folder location set in one or more filters is invalid.
I'm pretty sure that the computer could check that, and even tell me which folder is invalid.

> Please check your filters in Edit->Message Filters.

Does it link straigth to the filter that's broken?
Comment 8 Milan Crha 2012-12-10 13:45:45 UTC
Created attachment 231143 [details] [review]
eds patch

for evolution-data-server;

(In reply to comment #7)
> The message is sub-par for me:
> > One reason can be that folder location set in one or more filters is invalid.
> I'm pretty sure that the computer could check that, and even tell me which
> folder is invalid.

The current error message looks like this (it's with this patch included, see below):
   Error while Filtering Selected Messages.

   Failed to filter selected messages. One reason can be that folder location
   set in one or more filters is invalid. Please check your filters in
   Edit->Message Filters.
   Original error was: Execution of filter 'XX broken rule XX' failed:
   Invalid folder URI 'folder://1355145511.7145.14%40host/INBOX'

> > Please check your filters in Edit->Message Filters.
> 
> Does it link straigth to the filter that's broken?

It unfortunately doesn't, and even I agree with your proposal of "Edit Filter" button, then it cannot be done currently, due to design limitations. The thing is that even if I pass a rule name to the caller, then it cannot process it into an "Edit Filter" button, because it doesn't have access to this part of evolution. There is some ongoing effort to move certain parts of mailer into evolution-data-server, thus processes will be able to access mail through DBus. This filtering part is also going to be part of this code movement, thus the only outcome of the filter operation is a GError structure. I'd rather avoid "encoding" filter name into a GError message, especially because the error will be received by any application. Of course, sadly, the information about Edit->Message Filters may not be accurate there as well, but as long as we are currently the only user of it, then I guess it's fine. Maybe the API/design will change during the movement too, thus the whole this will be possible, though probably not.

Finally, this patch prefixes original error with a filter name, which is the most I can do right now.
Comment 9 Milan Crha 2012-12-10 13:47:23 UTC
Created attachment 231144 [details] [review]
evo patch

for evolution;

Hrm, I overlooked the outgoing filters, where the same error can happen, thus I added the descriptive message there as well.
Comment 10 Milan Crha 2012-12-10 13:51:49 UTC
Created commit 807d32c in eds master (3.7.3+)
Created commit c5eb6af in evo master (3.7.3+)