GNOME Bugzilla – Bug 578654
Wrong MusicBrainz IDs written
Last modified: 2009-11-24 17:26:48 UTC
Please describe the problem: Sound Juicer 2.26.0 writes the MusicBrainz IDs incorrectly to the tags. It uses the complete URI instead of just the UUID part. For example it uses http://musicbrainz.org/release/953fa66b-d805-41da-9319-c86d76918e48.html as the Album-ID but should only use 953fa66b-d805-41da-9319-c86d76918e48. Steps to reproduce: 1. Rip a CD which was found on MusicBrainz 2. Look at the written Tags Actual results: The complete Identifier (e.g. http://musicbrainz.org/release/953fa66b-d805-41da-9319-c86d76918e48.html) gets written to the file tags. Expected results: Only the UUID part of the MusicBrainz IDs gets written to the files. Does this happen every time? Yes Other information: Earlier versions of Sound Juicer did this correctly. This bug breaks compatibility with other software that uses the MusicBrainz IDs in the tags, e.g. MusicBrainz Picard.
Doh.
Ross, any chance this will be fixed soon? I tried to fix this myself, but I could not find the relevant code.
Created attachment 140992 [details] [review] Patch to fix MBIDs when using libmusicbrainz3 Finally found it. This only happens when using the libmusicbrainz3 backend, with libmusicbrainz2 it works as expected. Please note that the attached patch requires a patched libmusicbrainz3, since the current version does not expose the utility function extractUuid() via the C API. I've submitted a patch for libmusicbrainz at http://bugs.musicbrainz.org/ticket/5333.
Created attachment 140996 [details] [review] 0001 Use only the UUID part of MusicBrainz IDs
Comment on attachment 140996 [details] [review] 0001 Use only the UUID part of MusicBrainz IDs Excellent. If you can make that code conditional on mb_extract_uuid() being present (check in configure.in with mb_SetProxyCreds) and don't set the MB ID when it isn't present, then this will be ready for merging.
Created attachment 141112 [details] [review] 0002 Check for presence of mb_extract_uuid
Ok, I've added an additional patch to check for the function. This also fixes two small issues I overlooked when reworking the patch yesterday.
Ross, any chance that this patch will be applied? If there is anything that should be done just let me know. I'm happy to help.
Seems to fixed with sound-juicer 2.28.0 ... (ubuntu karmic beta)
Committed to git.