After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578562 - dshowdecwrapper missing check for GST_DISABLE_GST_DEBUG
dshowdecwrapper missing check for GST_DISABLE_GST_DEBUG
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.11
Other Windows
: Normal normal
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-10 00:04 UTC by David Hoyt
Modified: 2009-04-10 17:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Possible fix (1.12 KB, patch)
2009-04-10 00:04 UTC, David Hoyt 		reviewed Details | Review

Description David Hoyt 2009-04-10 00:04:17 UTC 
Compile error when GST_DISABLE_GST_DEBUG is defined. See attached patch for fix.
Comment 1 David Hoyt 2009-04-10 00:04:36 UTC 
Created attachment 132437 [details] [review]
Possible fix
Comment 2 Tim-Philipp Müller 2009-04-10 16:23:09 UTC 
I think it would be better to just remove the

  if (!dshowaudiodec_debug) {

which shouldn't be needed since the macro does this already. It looks like we can remove these CATEGORY_INIT lines in _class_init completely anyway though, because there's already a GST_DEBUG_CATEGORY_INIT in dshow_adec_register() etc.
Comment 3 David Hoyt 2009-04-10 16:31:52 UTC 
Sounds fine to me.
Comment 4 Tim-Philipp Müller 2009-04-10 17:09:18 UTC 
Should be fixed now - thanks for the bug report and patch!

 commit 2b1fcc75a740d2caa7774658eff1e6161d408c20
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Fri Apr 10 18:00:06 2009 +0100

    dshowdec: fix compilation with the debugging system disabled
    
    One GST_DEBUG_CATEGORY_INIT should be enough anyway.
    Fixes #578562 (spotted by David Hoyt).