GNOME Bugzilla – Bug 576411
DevelopInUfraw doesn't work properly in Dutch locale because the Dutch translation for "Photos" contains a ' character
Last modified: 2009-07-29 16:16:49 UTC
Please describe the problem: I use F-Spot in a Dutch environment, and there it creates a "Foto's" folder to import everything into. This works great, except when trying to develop RAW files: the DevelopInUFraw extension (or the shell?) cries when it's fed a filename with a single quote in it (for obvious reasons). I've attached a patch that fixes this by escaping the ' -> \' This is also Launchpad bug #346648 Steps to reproduce: 1. Set the Dutch locale 2. Import a RAW file into the default folder (so it becomes "Foto's/yyyy/mm/dd/img_1234.cr2") 3. Choose "Develop in Ufraw" from the menu Actual results: You get an "Open file" dialog from ufraw, because the filename isn't passed correctly. Expected results: UFRaw should open, as it does when I Does this happen every time? As long as the locale has the name of the Photos directory translated, and the translation contains any special character other than "(", ")" or " ", yes. Other information:
Created attachment 131185 [details] [review] Patch to also escape ' This patch fixes the immediate problem. A more structured approach might be needed to escape _all_ special characters...
(In reply to comment #0) > UFRaw should open, as it does when I + manually import into a folder that doesn't contain a "'" character.
Created attachment 138368 [details] [review] Better patch, part 1 This is part 1 of a better patch for the bug. Applied to Git Master
Created attachment 138369 [details] [review] Better patch, part 2 This is the second part of the better patch for this bug.
Probably needs fixing before 0.6 comes out.
I pushed a fix without the workaround hack called CheapEscape. Looks like GLib provides it now. Could you try it? commit 0c37de743fefb66570f638ed1698ceb1f512b083 Author: Ruben Vermeersch <ruben@savanne.be> Date: Wed Jul 29 16:44:12 2009 +0200 Replace CheapEscape by GLib.Shell.Escape. Fixes Bug 576411 – DevelopInUfraw doesn't work properly in Dutch locale because the Dutch translation for "Photos" contains a ' character MetaPixel is broken though, but it already was before this. extensions/Tools/DevelopInUFraw/DevelopInUFRaw.cs | 13 ++----------- extensions/Tools/DevelopInUFraw/Makefile.am | 1 + extensions/Tools/MetaPixel/Makefile | 1 + extensions/Tools/MetaPixel/MetaPixel.cs | 17 ++++------------- 4 files changed, 8 insertions(+), 24 deletions(-) and: commit 191ca03c159cf1977d0a046a80654795a4aa68d3 Author: Ruben Vermeersch <ruben@savanne.be> Date: Wed Jul 29 16:48:37 2009 +0200 Also escape the conf files. Based on a patch by Martijn van de Streek <martijn@vandestreek.net> extensions/Tools/DevelopInUFraw/DevelopInUFRaw.cs | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
The patch applied to current HEAD works for me!
Perfect, RESOLVED FIXED!