After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576323 - g-ir-compiler fails with constant in classes
g-ir-compiler fails with constant in classes
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
2.18.x
Other All
: Normal critical
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 568951
 
 
Reported: 2009-03-22 20:49 UTC by Didier "Ptitjes"
Modified: 2015-02-07 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes inner constant parsing (891 bytes, patch)
2009-03-22 20:52 UTC, Didier "Ptitjes" 		accepted-commit_now Details | Review

Description Didier "Ptitjes" 2009-03-22 20:49:29 UTC 
Steps to reproduce:
1. Make a gir file with a constant in a class
2. Compile it with g-ir-compiler


Stack trace:


Other information:
Inner constants put girparser.c in an invalide state.
Comment 1 Didier "Ptitjes" 2009-03-22 20:52:45 UTC 
Created attachment 131138 [details] [review]
Fixes inner constant parsing
Comment 2 Colin Walters 2009-03-23 20:39:04 UTC 
Are we generating inner constants currently from the scanner, or is this something Vala is doing?

I see we're only doing the push here:

	  if (ctx->state == STATE_NAMESPACE)
	    {
	      push_node (ctx, (GIrNode *) constant);

So this change looks good to commit.
Comment 3 Didier "Ptitjes" 2009-03-23 20:52:03 UTC 
It seems the scanner currently don't recognize inner constants. Indeed, VALUE_COLLECT_FORMAT_MAX_LENGTH and VALUE_NOCOPY_CONTENTS would be good candidates to be inner constants of the Value record. (cf. GObject-2.0.gir) Maybe a bug should be filed for this. 

Anyway Vala does for sure.
Comment 4 André Klapper 2015-02-07 16:55:06 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]