After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575963 - prioritize some toolbar buttons so that their labels show up
prioritize some toolbar buttons so that their labels show up
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal trivial
: 0.13.3
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-19 14:01 UTC by Jean-François Fortin Tam
Modified: 2010-02-05 22:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2009-03-19 14:01:41 UTC
Currently, PiTiVi's toolbars adapt to GNOME's global toolbar preferences setting (in "Appearance"), which is a good thing. 

What's missing is "priority text" for our most important toolbar buttons. "Render" would be a good candidate for this.

In pygtk, this is done with the "is-important" property: http://pygtk.org/pygtk2reference/class-gtktoolitem.html

An example result is shown in the second screenshot on http://library.gnome.org/devel/hig-book/stable/toolbars-labels-tooltips.html.en
Comment 1 Brandon Lewis 2009-07-13 21:01:04 UTC
I need a little help with this one, because I'm not sure which buttons to consider "important." 

What other buttons should we prioritize aside from render? New, open, and save, as in that example? Or maybe just import?
Comment 2 Jean-François Fortin Tam 2009-07-14 01:23:05 UTC
My personal take on this. Important buttons:
- Save
- Import (the Add button)
- Undo (bug 588258)
- Render

Not important:
- New (rarely used for common users, I would presume)
- Fullscreen (power-user feature)

I'm unsure about the Open project button. I somewhat thought of leaving it unprioritized to give more importance to the Import button, which may be used much more often (besides, perhaps users will load pitivi projects by clicking on the .xptv files in their file manager).


As for the timeline toolbar, I'm unsure how many buttons we plan to have in there. Perhaps they should all be left "icon only" because they are of equal importance (?) and to save space, not sure. They will probably be much more numerous than the main toolbar's buttons, so there may be space constraints too.
Comment 3 Edward Hervey 2009-07-15 09:18:58 UTC
What Jeff said makes sense, let's follow that. We can always change it later on, but it's a good start.
Comment 4 Brandon Lewis 2009-07-21 20:01:21 UTC
commit b4efc988383de6e391ce6120aff73f1272fd1db4
Author: Brandon Lewis <brandon_lewis@berkeley.edu>
Date:   Tue Jul 21 12:53:49 2009 -0700

    UI: set is_important property of Save, Import, Render, and Undo actions
    closes bug 575963
Comment 5 Jean-François Fortin Tam 2010-02-04 02:52:31 UTC
Please update the target milestone :)