GNOME Bugzilla – Bug 575545
[gstffmpegenc] Wrong usage of AVCodec.pix_fmts
Last modified: 2009-07-31 11:27:55 UTC
In the _getcaps() implementation, we are being way too restrictive when analyzing the possible PixFmt usable by the encoder. If there is a list of usable pix_fmt in AVCodec.pix_fmts, we should use those to get caps from gstffmpegcodecmap without creating a AVCodecContext and opening an actual encoder.
Created attachment 130739 [details] [review] If we have AVCodec.pix_fmts, get the caps from gstffmpegcodecmap.c
Edward, what's keeping this patch from being committed? :)
Ping?
I'm guessing we were in a freeze when I submitted the original patch. We can commit it.. but we'll need to make sure it doesn't introduce any regression (by running it through insanity).
Ok, then commit it and it will be tested extensively before the next release ;)
SIR YES SIR ! commit 56887682d058c40b911bdd57cc8c59aabd5cb79b Author: Edward Hervey <bilboed@bilboed.com> Date: Fri Jul 31 13:27:28 2009 +0200 gstffmpegenc: Try getting the caps for the declared pixfmt without a context. PixFmt that are declared in AVCodec.pix_fmts are ones which are 'officially' declared as being supported. We should therefore not have to create a AVCodecContext and open an encoder to know if it's supported or not. Also, doing it this way allows us to better pickup configuration overrides we have in gstffmpegcodecmap for some codecs (like restrictions on width, height, framerate like it's the case for dnxhd). Fixes #575545