GNOME Bugzilla – Bug 575326
Playlists uploaded to Dap are not separated according to their format
Last modified: 2020-03-17 08:18:56 UTC
Please describe the problem: I think the root cause of bug 434237 is this more generic bug. Steps to reproduce: 1. Import 2 videos. 2. Import 2 songs (beware, both should have Albums specified or you'll hit bug 573683). 3. Sync to iPod. Actual results: All default playlists are stored in the root of the iPod source. Thus, in the iPod device they're mixed as well. Expected results: The "unheard" playlist should be below the Music subsource of the iPod. The "unwatched" playlist should be below the Video subsource of the iPod. When accessing the music playlists on the iPod, the "unwatched" one should not appear there. Does this happen every time? Yes. Other information:
Created attachment 130631 [details] screenshot
Created attachment 162287 [details] [review] Patch v1 This was actually a small bug in the Dap library, so it is not specific to iPod.
I'm pretty sure your patch will break the actual sync logic, which looks for PlaylistSources beneath the main DapSource.
Created attachment 162575 [details] [review] Patch v2 (In reply to comment #3) > I'm pretty sure your patch will break the actual sync logic, which looks for > PlaylistSources beneath the main DapSource. You were right! sorry for not testing exhaustively. This fixes it.
Review of attachment 162575 [details] [review]: ::: src/Dap/Banshee.Dap/Banshee.Dap/DapSource.cs @@ +295,3 @@ + if (lib.Equals (ServiceManager.SourceManager.MusicLibrary)) { + { + internal void AddPlaylistSource (PlaylistSource playlistsource, LibrarySource lib) Did you test the scenario when SupportsVideo is false and thus video_group_source is null?
Thanks for the review. (In reply to comment #5) > Review of attachment 162575 [details] [review]: > > ::: src/Dap/Banshee.Dap/Banshee.Dap/DapSource.cs > @@ +295,3 @@ > + if (lib.Equals (ServiceManager.SourceManager.MusicLibrary)) { > + { > + internal void AddPlaylistSource (PlaylistSource playlistsource, > LibrarySource lib) > > Did you test the scenario when SupportsVideo is false and thus > video_group_source is null? Actually, no. But, as far as I understand, if SupportsVideo is false, lib could never equal VideoLibrary because that DapLibrarySync instance would never exist. BTW, did you test or only review? Because I'm thinking I forgot to test with manual sync mode (although I guess the worse thing to happen would be that in this scenario the playlists are simply children of the dap source, which is not something bad, but just that this bug is not fixed for that case). I'll test this, and I'll also force SupportsVideo to false to make sure I test what you mention too.
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.