Bug 575318 – Crash in excel_font_hash

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 575318 - Crash in excel_font_hash


Summary:	Crash in excel_font_hash


Status:	RESOLVED FIXED

Product:	Gnumeric
Classification:	Applications
Component:	import/export MS Excel (tm)
Version:	git master
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Jody Goldberg
QA Contact:	Jody Goldberg

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-03-14 02:23 UTC by sum1
Modified:	2009-03-14 18:07 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
patch for goffice (716 bytes, patch) 2009-03-14 14:49 UTC, Jean Bréfort	committed	Details \| Review

Description sum1 2009-03-14 02:23:57 UTC

Version: r17197
OS: Ubuntu Intrepid

Steps to reproduce:
- Download Attachment 98088 [details] (a .gnumeric file from Bug 491328)
- ssconvert attachment.gnumeric /tmp/foo.xls


Backtrace:

Program received signal SIGSEGV, Segmentation fault.

+ Trace 213465

Thread 3067057920 (LWP 24141)

#0 IA__g_str_hash
at /build/buildd/glib2.0-2.18.2/glib/gstring.c line 95
#1 excel_font_hash
at ms-excel-write.c line 2034
#2 IA__g_hash_table_lookup
at /build/buildd/glib2.0-2.18.2/glib/ghash.c line 118
#3 two_way_table_key_to_idx
at ms-excel-util.c line 226
#4 two_way_table_put
at ms-excel-util.c line 133
#5 put_efont
at ms-excel-write.c line 2105
#6 excel_font_from_go_font
at ms-excel-write.c line 2126
#7 extract_gog_object_style
at ms-excel-write.c line 5778
#8 extract_gog_object_style
at ms-excel-write.c line 5797
#9 extract_gog_object_style
at ms-excel-write.c line 5797
#10 extract_gog_object_style
at ms-excel-write.c line 5797
#11 excel_write_state_new
at ms-excel-write.c line 5895
#12 excel_save
at boot.c line 258
#13 excel_dsf_file_save
at boot.c line 308
#14 go_plugin_loader_module_func_file_save
at go-plugin-loader-module.c line 323
#15 go_plugin_file_saver_save
at go-plugin-service.c line 749
#16 go_file_saver_save
at file.c line 705
#17 wbv_save_to_output
at workbook-view.c line 850
#18 wb_view_save_to_uri
at workbook-view.c line 887
#19 wb_view_save_as
at workbook-view.c line 923
#20 convert
at ssconvert.c line 337
#21 main
at ssconvert.c line 402

Comment 1 Morten Welinder 2009-03-14 12:28:27 UTC

We somehow end up with the font description "Bold 12" for which pango cannot
give us a family name.

Comment 2 Morten Welinder 2009-03-14 13:07:31 UTC

Crash fixed.  Not the cause, though.

Comment 3 Morten Welinder 2009-03-14 14:03:25 UTC

I fixed some criticals relating to comments without any author.

Jean, the "Bold 12" font description appears to come from over in goffice
land.  Should we do anything about that?

(Apart from that, this report can be closed as fixed.)

Comment 4 Jean Bréfort 2009-03-14 14:49:08 UTC

Created attachment 130656 [details] [review]
patch for goffice

One of the styles in the gnumeric file has no font family name. Attached patch adds a default family when this occurs.

Comment 5 Morten Welinder 2009-03-14 17:58:01 UTC

Looks good.  Please commit.

Comment 6 Jean Bréfort 2009-03-14 18:05:16 UTC

Fixed in trunk.