After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575046 - divx renders choppy audio (mp3parse?)
divx renders choppy audio (mp3parse?)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: dont know
git master
Other Linux
: Normal normal
: 0.10.11
Assigned To: Jan Schmidt
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-12 09:04 UTC by Sebastien Bacher
Modified: 2009-03-13 23:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (3.45 KB, patch)
2009-03-13 22:43 UTC, Jan Schmidt
none Details | Review

Description Sebastien Bacher 2009-03-12 09:04:57 UTC
the bug has been opened on https://bugs.launchpad.net/bugs/338347

"I'm in Jaunty and I was trying to watch a divx movie.
624x352 DivX MPEG-4 Version 5 24 frames per second
MPEG 1 Audio, Layer 3 (MP3) Stereo 48000 Hz 128kbps

the audio is really choppy. I transcoded the video to xvid (only the video, I copied the audio) and it works well.

gstreamer0.10-ffmpeg 0.10.6-1

http://launchpadlibrarian.net/23520788/video.divx"
Comment 1 Sebastien Bacher 2009-03-12 09:05:40 UTC
the video lags there too using 0.10.6.2 now, ffplay plays it just fine on the same installation
Comment 2 Edward Hervey 2009-03-12 09:36:03 UTC
I can reproduce the behaviour with:
filesrc ! avidemux ! mp3parse ! mad ! alsasink

But the 'choppyness' disappears if:
* I remove mp3parse or
* I set alsasink sync=False.

I'm guessing it's a mp3parse bug then ?
Comment 3 Nicolò Chieffo 2009-03-12 10:44:42 UTC
I want to add that the file is created using 

dd if=complete.avi of=test_divx.avi bs=1k count=512

just to reduce the size. so the file is not complete, but the complete file has this problem too.
Comment 4 Wim Taymans 2009-03-13 16:52:39 UTC
it's an mp3parse bug.
Comment 5 Jan Schmidt 2009-03-13 22:43:29 UTC
Created attachment 130612 [details] [review]
proposed patch

This fixes the bug by relaxing the threshold for incoming timestamps to override our interpolated timestamp, and by not setting discont unless upstream signals a discont.
Comment 6 Jan Schmidt 2009-03-13 22:56:18 UTC
Fixed in GIT:

commit d2c6f0b2b69f484ff82578e82d97090317be35bf
Author: Jan Schmidt <thaytan@noraisin.net>
Date:   Fri Mar 13 19:23:12 2009 +0000

    mp3parse: Fix glitches in the output when playing (for e.g.) AVI
    
    Don't introduce glitches in the output by a) relaxing the threshold for
    taking upstream timestamps in preference to our calculated timestamps and
    b) only set the discont flag on outgoing buffers in response to an incoming
    discont buffer.
    
    Fixes: #575046