Bug 574706 – segfault when not saving a project with errors

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 574706 - segfault when not saving a project with errors


Summary:	segfault when not saving a project with errors


Status:	RESOLVED FIXED

Product:	glade
Classification:	Applications
Component:	general
Version:	3.5.x
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Glade 3 Maintainers
QA Contact:	Glade 3 Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-03-10 02:51 UTC by Adrian Bunk
Modified:	2009-03-16 19:37 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fixes access to invalid/unset GError (730 bytes, patch) 2009-03-16 03:04 UTC, Tristan Van Berkom	none	Details \| Review

Description Adrian Bunk 2009-03-10 02:51:51 UTC

Steps to reproduce:
1. Start glade 3.5.7
2. Open a libglade .glade file containing stuff only supported in libglade format
3. "Save As" with File Format GtkBuilder
4. "Project foobar has errors, save anyway?" dialog pops up, Details contains "... is only supported in libglade format" messages
5. Answer "No"

Stack trace:
Program received signal SIGSEGV, Segmentation fault.

+ Trace 213307

Thread 140152741353344 (LWP 24343)

#0 save
at glade-window.c line 1184
#1 save_as
at glade-window.c line 1305
#2 IA__g_closure_invoke
at /build/buildd/glib2.0-2.18.4/gobject/gclosure.c line 767
#3 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.18.4/gobject/gsignal.c line 3244
#4 IA__g_signal_emit_valist
at /build/buildd/glib2.0-2.18.4/gobject/gsignal.c line 2977
#5 IA__g_signal_emit
at /build/buildd/glib2.0-2.18.4/gobject/gsignal.c line 3034
#6 _gtk_action_emit_activate
at /tmp/buildd/gtk+2.0-2.14.7/gtk/gtkaction.c line 885
#7 IA__g_closure_invoke
at /build/buildd/glib2.0-2.18.4/gobject/gclosure.c line 767
#8 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.18.4/gobject/gsignal.c line 3244
#9 IA__g_signal_emit_valist
at /build/buildd/glib2.0-2.18.4/gobject/gsignal.c line 2977
#10 IA__g_signal_emit
at /build/buildd/glib2.0-2.18.4/gobject/gsignal.c line 3034
#11 IA__gtk_widget_activate
at /tmp/buildd/gtk+2.0-2.14.7/gtk/gtkwidget.c line 4776
#12 IA__gtk_menu_shell_activate_item
at /tmp/buildd/gtk+2.0-2.14.7/gtk/gtkmenushell.c line 1139
#13 gtk_menu_shell_button_release
at /tmp/buildd/gtk+2.0-2.14.7/gtk/gtkmenushell.c line 678
#14 _gtk_marshal_BOOLEAN__BOXED
at /tmp/buildd/gtk+2.0-2.14.7/gtk/gtkmarshalers.c line 84
#15 IA__g_closure_invoke
at /build/buildd/glib2.0-2.18.4/gobject/gclosure.c line 767
#16 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.18.4/gobject/gsignal.c line 3282
#17 IA__g_signal_emit_valist
at /build/buildd/glib2.0-2.18.4/gobject/gsignal.c line 2987
#18 IA__g_signal_emit
at /build/buildd/glib2.0-2.18.4/gobject/gsignal.c line 3034
#19 gtk_widget_event_internal
at /tmp/buildd/gtk+2.0-2.14.7/gtk/gtkwidget.c line 4745
#20 IA__gtk_propagate_event
at /tmp/buildd/gtk+2.0-2.14.7/gtk/gtkmain.c line 2391
#21 IA__gtk_main_do_event
at /tmp/buildd/gtk+2.0-2.14.7/gtk/gtkmain.c line 1596
#22 gdk_event_dispatch
at /tmp/buildd/gtk+2.0-2.14.7/gdk/x11/gdkevents-x11.c line 2365
#23 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.18.4/glib/gmain.c line 2144
#24 g_main_context_iterate
at /build/buildd/glib2.0-2.18.4/glib/gmain.c line 2778
#25 IA__g_main_loop_run
at /build/buildd/glib2.0-2.18.4/glib/gmain.c line 2986
#26 IA__gtk_main
at /tmp/buildd/gtk+2.0-2.14.7/gtk/gtkmain.c line 1200
#27 main
at main.c line 186



Other information:

Comment 1 Tristan Van Berkom 2009-03-16 03:04:52 UTC

Created attachment 130722 [details] [review]
Fixes access to invalid/unset GError

Quick fix for the crasher.

Comment 2 Tristan Van Berkom 2009-03-16 19:37:23 UTC

Fixed in 3.6 release.