After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574622 - GtkEntry: Should we wrap icon-press and icon-release signals?
GtkEntry: Should we wrap icon-press and icon-release signals?
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkEntry
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-03-09 11:20 UTC by Murray Cumming
Modified: 2009-03-12 15:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Murray Cumming 2009-03-09 11:20:38 UTC 
The new GtkEntry signals, icon-press and icon-release, use G_SIGNAL_ACTION, bug G_SIGNAL_ACTION signals are usually just "key-binding" signals that should not be wrapped by language bindings or used by applications.

If these should be used then that should be documented.
Comment 1 Matthias Clasen 2009-03-10 16:52:44 UTC 
Yeah, these should not be action signals. They are really analogous to GtkWidget::button-press/release-event.

I've sent a freeze break request to fix this up before 2.16
Comment 2 Matthias Clasen 2009-03-10 17:49:17 UTC 
2009-03-10  Matthias Clasen  <mclasen@redhat.com>

        Bug 574622 – GtkEntry: Should we wrap icon-press and icon-release
        signals?

        * gtk/gtkentry.c: ::icon-press and ::icon-release are not
        action signals. Pointed out by Murray Cumming
Comment 3 Murray Cumming 2009-03-12 15:16:37 UTC 
Thanks.

The documentation should maybe also mention the GdkEventButton type for the 2nd parameter, if that is what is meant. The signal registration is not capable of stating this with GTypes.