GNOME Bugzilla – Bug 574416
rtp{theora,vorbis}depay should accept in-line configuration (too)
Last modified: 2010-04-30 14:29:33 UTC
rtptheoradepay should also accept in-band configuration. It should also just drop the buffers until it gets a configuration string (instead of dying).
For Vorbis, this is a MUST in RFC 5215. While out of band config is a SHOULD.
Created attachment 158150 [details] [review] rtptheoradepay: Ignore packets without a known codebook Don't produce an error if a packet is received without a valid codebook, it's possible that the codebook will just be coming later.
Created attachment 159329 [details] [review] rtpvorbisdepay: also accept in-line configuration
Created attachment 159331 [details] [review] rtptheoradepay: also accept in-band configuration
Review of attachment 159331 [details] [review]: ::: gst/rtp/gstrtptheoradepay.c @@ +626,3 @@ + /* fatal, as we otherwise risk carrying on without output */ + GST_ELEMENT_ERROR (rtptheoradepay, STREAM, DECODE, + (NULL), ("Packet contains invalid configuration")); I would prefer if we just dropped packets until a valid config comes. And maybe emit some kind of non-fatal message. This way, when we implement AVPF, we can inform the other side to re-send it. That said, I plan to do AVPF in the not so distant future, so I'll figure out the message and stuff.
Given the to-be-implemented-nature, leaving the GST_ELEMENT_ERROR for now (easy to change), the following commit should take care so far: commit be5ffd96fe4289a37a34df289b1f98975acff293 Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Thu Apr 22 12:28:22 2010 +0200 rtptheoradepay: also accept in-band configuration Fixes #574416 (theora). commit a344cfba2720a447bf354066dec4aaeb3b6c4d05 Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Thu Apr 22 12:27:35 2010 +0200 rtpvorbisdepay: also accept in-line configuration Fixes #574416 (vorbis). commit 7bc3253761de5ed0f503b560adf7f0e6396a7c30 Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Wed Apr 7 17:21:55 2010 -0400 rtptheoradepay: Ignore packets without a known codebook Don't produce an error if a packet is received without a valid codebook, it's possible that the codebook will just be coming later. See #574416.