After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573527 - Wrong shell to run config.status in Makefile.in.in
Wrong shell to run config.status in Makefile.in.in
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2009-02-28 11:39 UTC by Loïc Minier
Modified: 2009-03-01 07:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch modeled on the gettext fix (508 bytes, patch)
2009-02-28 11:39 UTC, Loïc Minier 		none Details | Review

Description Loïc Minier 2009-02-28 11:39:18 UTC 
Hi,

config.status is generated based on the shell detected in configure and should
be called with the CONFIG_SHELL instead of the default make SHELL (/bin/sh).

This was discovered recently in gettext and fixed:
http://lists.gnu.org/archive/html/bug-gnu-utils/2009-02/msg00054.html

Original bug:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/332840

Bye
Comment 1 Loïc Minier 2009-02-28 11:39:42 UTC 
Created attachment 129732 [details] [review]
Proposed patch modeled on the gettext fix
Comment 2 Loïc Minier 2009-02-28 11:43:03 UTC 
Also, I find it more elegant to call config.status the way gettext does:
Makefile: Makefile.in.in Makevars $(top_builddir)/config.status
@POMAKEFILEDEPS@
        cd $(top_builddir) \
          && $(SHELL) ./config.status $(subdir)/$@.in po-directories
and it has support for multiple po/ dirs -- which was the need of Gtk+ which
triggered its own set of issues, see bug #573515.

So I kind of wonder whether it makes sense to duplicate this Makefile.in.in
infrastructure and whether it would be possible to move this part to upstream
gettext nowadays?

If you care to do it like gettext, change the Makefile rule to read:
        cd $(top_builddir) \
          && $(SHELL) ./config.status $(subdir)/$@.in
Comment 3 Matthias Clasen 2009-03-01 07:06:51 UTC 
        * Makefile.in.in: Don't hardcode /bin/sh as shell.
        Reported by Loïc Minier