GNOME Bugzilla – Bug 572850
build error in Alphabet.cpp
Last modified: 2009-03-09 19:13:14 UTC
http://svn.gnome.org/viewvc/dasher?view=revision&revision=3615 broke the build (as seen on several buildslaves at http://build.gnome.org/dasher) with the following error: g++ (...) -c -o Alphabet.o `test -f 'Alphabet/Alphabet.cpp' || echo './'`Alphabet/Alphabet.cpp In file included from Alphabet/../LanguageModelling/../DasherComponent.h:4, from Alphabet/../LanguageModelling/LanguageModel.h:15, from Alphabet/../AlphabetManager.h:25, from Alphabet/../AlphabetManagerFactory.h:4, from Alphabet/../TrainingHelper.h:25, from Alphabet/Alphabet.cpp:22: Alphabet/../LanguageModelling/../SettingsStore.h:21: warning: declaration 'struct Dasher::CEventHandler' does not declare anything Alphabet/../LanguageModelling/../SettingsStore.h:22: warning: declaration 'struct Dasher::CParameterNotificationEvent' does not declare anything Alphabet/Alphabet.cpp: In constructor 'Dasher::CAlphabet::utf8_length::utf8_length()': Alphabet/Alphabet.cpp:131: error: 'memset' was not declared in this scope
same here.
Created attachment 129656 [details] [review] patch
Awesome. Second issue: make[4]: Entering directory `/home/andre/svn-gnome/dasher/Data/Help/Gnome' xsltproc -o dasher-eu.omf --stringparam db2omf.basename dasher --stringparam db2omf.format 'docbook' --stringparam db2omf.dtd "-//OASIS//DTD DocBook XML V4.1.2//EN" --stringparam db2omf.lang eu --stringparam db2omf.omf_dir "/home/andre/opt-gnome/share/omf" --stringparam db2omf.help_dir "/home/andre/opt-gnome/share/gnome/help" --stringparam db2omf.omf_in "/home/andre/svn-gnome/dasher/Data/Help/Gnome/dasher.omf.in" `/home/andre/opt-gnome/bin/pkg-config --variable db2omf gnome-doc-utils` eu/dasher.xml || { rm -f "dasher-eu.omf"; exit 1; } db2omf: Could not construct the OMF creator element. Add an author element to dasher.xml. $:andre\> rm Data/Help/Gnome/eu/dasher.xml $:andre\> rm Data/Help/Gnome/eu/dasher-eu.omf $:andre\> rm Data/Help/Gnome/eu/Makefile.am fixes this.
Both fixes committed. WORKSFORME. Reopen if there's still issues. Thanks. If any maintainers read this (I doubt): I consider this application unmaintained and will continue to just commit stuff when I'm in the mood to.
Thank you for committing the fixes. I just wonder why I didn't see the problem compiling on ubuntu 8.04.2 (=> gcc 4.2.4) (and NetBSD and visual studio 2005) from ubuntu build log: mv -f .deps/AlphIO.Tpo .deps/AlphIO.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/pixman-1 -DORBIT2=1 -pthread -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DORBIT2=1 -pthread -I/usr/include/bonobo-activation-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/gnome-keyring-1 -I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/libxml2 -I/usr/include/pango-1.0 -I/usr/include/gail-1.0 -I/usr/include/freetype2 -I/usr/include/atk-1.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/at-spi-1.0 -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libxml2 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/pixman-1 -DORBIT2=1 -pthread -I/usr/include/libgnome-2.0 -I/usr/include/orbit-2.0 -I/usr/include/gconf/2 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libxml2 -I/usr/include/pango-1.0 -I/usr/include/gail-1.0 -I/usr/include/freetype2 -I/usr/include/atk-1.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/libpng12 -I/usr/include/pixman-1 -DWNCK_I_KNOW_THIS_IS_UNSTABLE -I./../DasherCore -DPROGDATA=\"/usr/local/share/dasher\" -I../../intl -I../../intl -g -O2 -MT Alphabet.o -MD -MP -MF .deps/Alphabet.Tpo -c -o Alphabet.o `test -f 'Alphabet/Alphabet.cpp' || echo './'`Alphabet/Alphabet.cpp mv -f .deps/Alphabet.Tpo .deps/Alphabet.Po xsltproc -o dasher-eu.omf --stringparam db2omf.basename dasher --stringparam db2omf.format 'docbook' --stringparam db2omf.dtd "-//OASIS//DTD DocBook XML V4.1.2//EN" --stringparam db2omf.lang eu --stringparam db2omf.omf_dir "/usr/local/share/omf" --stringparam db2omf.help_dir "/usr/local/share/gnome/help" --stringparam db2omf.omf_in "/data/prlw1/dasher/Data/Help/Gnome/dasher.omf.in" `/usr/bin/pkg-config --variable db2omf gnome-doc-utils` eu/dasher.xml || { rm -f "dasher-eu.omf"; exit 1; } xsltproc -o dasher-fr.omf --stringparam db2omf.basename dasher --stringparam db2omf.format 'docbook' --stringparam db2omf.dtd "-//OASIS//DTD DocBook XML V4.1.2//EN" --stringparam db2omf.lang fr --stringparam db2omf.omf_dir "/usr/local/share/omf" --stringparam db2omf.help_dir "/usr/local/share/gnome/help" --stringparam db2omf.omf_in "/data/prlw1/dasher/Data/Help/Gnome/dasher.omf.in" `/usr/bin/pkg-config --variable db2omf gnome-doc-utils` fr/dasher.xml || { rm -f "dasher-fr.omf"; exit 1; } In other words, what test can I do to prevent another disastrous commit? (Thought about avoiding the memset by making the array static - thoughts?)
(In reply to comment #5) > In other words, what test can I do to prevent another disastrous commit? No idea and not my area, sorry. :-/