GNOME Bugzilla – Bug 571743
Get rid of deprecated libgnomecanvas
Last modified: 2009-04-09 03:18:00 UTC
According to http://live.gnome.org/TwoPointTwentyfive/Platform libgnomecanvas has been deprecated for years and should be removed. $:\> grep -r "#include <libgnomecanvas/" . ./gtkhtml/components/html-editor/gi-color-combo.c:#include <libgnomecanvas/gnome-canvas.h> ./gtkhtml/components/html-editor/gi-color-combo.c:#include <libgnomecanvas/gnome-canvas-pixbuf.h> ./gtkhtml/components/html-editor/gi-color-combo.c:#include <libgnomecanvas/gnome-canvas-rect-ellipse.h> ./gtkhtml/components/html-editor/gi-color-palette.c:#include <libgnomecanvas/gnome-canvas.h> ./gtkhtml/components/html-editor/gi-color-palette.c:#include <libgnomecanvas/gnome-canvas-rect-ellipse.h> ./gtkhtml/components/html-editor/gi-color-palette.h:#include <libgnomecanvas/gnome-canvas.h> I'm also surprised that I can't find anything like "libgnomecanvas-2.0" in configure.in...
Created attachment 130014 [details] [review] delete depens from bonobo in makefile.(after patch you can delete components/html-editor) I found this files used to compile libgnome-gtkhtml-editor-*(.so/.la), but this files not installed when run make install. I think early use as bonobo component, it's right? May be need delete this component because bonobo deprecated?
Uh, I just realize that all libgnomecanvas tools are in /gtkhtml/components/html-editor. After I had filed this I discussed gtkhtml's bonobo dep... <mbarnes> gtkhtml doesn't have a bonobo issue any more. that's what the 2.24 composer rewrite solved. the old html-editor composer based on bonobo is still in the tarball. but it's deprecated and not built by default anymore. we could dump html-editor today if we wanted. all "#include <bonobo" are in /components/html-editor/ except for the one in ./gtkhtml/gtkhtml/testgtkhtml.c The plan is to remove it for 2.27. If you're looking for a real challenge: Bug 571742. :-)
Created attachment 130343 [details] [review] delete depends from bonobo in testgtkhtml
May be also need replace using libgnomeui to GtkUIManager(or some other implementation for menu)?
As already said, gtkhtml/components/html-editor will DIE in a few weeks. No work needed for this - it will be duplicated efforts. Getting rid of libgnomeui is something needed for evolution and gtkhtml, yes (and a different issue). But evolution is currently more important, as gtkhtml might be replaced by webkit for 2.28 or 2.30.
It seems fine to me. Matt, any thoughts?
Branch and drop /gtkhtml/components/html-editor and then see what's still left. :-P
I see some minor issues in the test app that I'd want to clean up (if only to fix compiler warnings), but the configure.in / Makefile.am changes look good. Approved for after we branch.
@Srini: Any chance we could branch GtkHtml early? I doubt we'll be making many changes for 3.26.1.
Branched & announced.
Great, thanks Srini. I'll put html-editor out of its misery.
Committed Denis' patch and nuked html-editor. Revision 9196.
No trace of libgnomecanvas left in GtkHtml. I guess we're done here.