GNOME Bugzilla – Bug 571713
The search replace doesn work fine
Last modified: 2019-02-27 15:15:46 UTC
Since the original strings are not editable, the replace dialog should only select the translated strings. Plus, sometimes it doesn't select/highligh the expressions properly: this is, when there are at least two (only tested with two) strings to replace in the same msgid or msgstr, the second one is usually not selected (use the Search button).
Hello, This bug isn't dead although it's very old. I have exactly the same problem with version 2.91.4 of gtranslator. Besides, the search function is _very_ slow with large files. Best regards, Therese
I just tested the search function with 4 occurrences of the keyword “copyright” in the same string (# 330 from http://www.gnu.org/licenses/po/gpl-faq.fr.po ): “Only the copyright holders for the program can legally authorize this exception. If you wrote the whole program yourself, then assuming your employer or school does not claim the copyright, you are the copyright holder—so you can authorize the exception. But if you want to use parts of other GPL-covered programs by other authors in your code, you cannot authorize the exception for them. You have to get the approval of the copyright holders of those programs.” Search in the original text only: The first occurrence is highlighted. The second one is apparently found but not highlighted. Repeating the search doesn't find anything more in string 330, but highlights the first occurrence of “copyright” in string 340. Search in both the original and the translated texts: Instead of finding the third occurrence in the original string, it highlights the first occurrence in the translated string. Therese
Yes, this bug is atill alive in the last version. We are working on it to get it fixed. I hope this issue will be solved for the next release. When we have a fix for it, we will close all the related bugs, so you will be notied about it. BTW, many thanks for your feedback :)
Created attachment 242193 [details] [review] Patch for the search&replace function I try to fix this bug. I hope it could help!
(In reply to comment #4) > Created an attachment (id=242193) [details] [review] > Patch for the search&replace function > > I try to fix this bug. I hope it could help! Many thanks from a basic user! :) I hope this patch will get accepted soon.
Review of attachment 242193 [details] [review]: Just one minor comment, gtranslator uses only spaces and you seem to mix some tabs around, please use just 2 spaces indentation. Also put the correct mail for the commit message.
Mickael, can you please update the patch?
We are mass-closing old gtranslator issues as the latest versions of gtranslator (3.30 or later) should fix most of the reported problems and as there is unfortunately no capacity to retest all of them separately. https://mail.gnome.org/archives/desktop-devel-list/2019-February/msg00059.html If the issue described in this report still happens in gtranslator version 3.30 or later, please file a new ticket under https://gitlab.gnome.org/GNOME/gtranslator/issues/ - thanks for your understanding! We are sorry that your report was not handled / fixed after you reported it - many free and open source software projects receive more bug reports and feature requests than they have developers who have free time to work on them. If you would like to get involved and contribute on gtranslator code, please check https://wiki.gnome.org/Git/Developers