GNOME Bugzilla – Bug 571495
Migrate from deprecated gnome_execute to g_spawn/xdg-terminal
Last modified: 2014-10-05 19:40:55 UTC
To get rid of libgnome and according to http://live.gnome.org/LibgnomeMustDie , gnome-exec shall be replaced by GSpawn which covers all of the useful parts of gnome-exec. gnome_execute_terminal* can be implemented using xdg-terminal (which will use "the active desktop's terminal program" rather than "the gnome-configured terminal program") See http://library.gnome.org/devel/libgnome/stable/libgnome-gnome-exec.html http://library.gnome.org/devel/glib/stable/glib-Spawning-Processes.html ./gnome-commander/plugins/fileroller/file-roller-plugin.c: gnome_execute_shell (t, cmd); ./gnome-commander/plugins/fileroller/file-roller-plugin.c: gnome_execute_shell (active_dir_path, cmd); ./gnome-commander/src/utils.cc: gnome_execute_shell (dir, command); ./gnome-commander/src/gnome-cmd-user-actions.cc: gnome_execute_shell (dir && gnome_cmd_dir_is_local (dir) ? dir_path.c_str() : NULL, cmd.c_str()); ./gnome-commander/src/gnome-cmd-user-actions.cc: gnome_execute_terminal_shell (dpath, NULL);
Created attachment 133036 [details] [review] Patch removing gnome_execute_shell Let me propose a patch for removing gnome_execute_shell. What's xdg-terminal? I can't find any information on how to use it.
ping - can this get a review?
Review of attachment 133036 [details] [review]: Partially committed (file-roller-plugin.c | gnome-cmd-user-actions.cc). Part dealing with utils.cc needs some more evaluation.
Hi, the remaining issue with utils.cc has been fixed in gcmd's software repository. The fix will go into the next release, v1.4.4. Best wishes, Uwe