After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571150 - aspectratiocrop : Memory leak
aspectratiocrop : Memory leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-10 10:29 UTC by Edward Hervey
Modified: 2009-02-10 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Memory leak fix (715 bytes, patch)
2009-02-10 10:31 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2009-02-10 10:29:22 UTC
aspectratiocrop doesn't call the parent class (GstBin) finalize implementation, resulting in a memory leak of the contained elements.
Comment 1 Edward Hervey 2009-02-10 10:31:39 UTC
Created attachment 128361 [details] [review]
Memory leak fix

Call the parent class finalize implementation.
Comment 2 Edward Hervey 2009-02-10 10:34:31 UTC
commit f1221b0c345accec65b81e54abff1a3b75bcfaee
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Tue Feb 10 11:27:51 2009 +0100

    aspectratiocrop: Don't forget to call parent finalize implementation.
    
    This fixes a memory leak (leaking the contained elements of the bin).
    
    Fixes #571150