GNOME Bugzilla – Bug 571038
[osxvideosink] build fail
Last modified: 2009-02-10 07:44:55 UTC
osxvideosink doesn't build anymore Making all in osxvideo /bin/sh ../../libtool --tag=disable-static --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -g -O2 -I../../gst-libs -I../../gst-libs -D_REENTRANT -I/Users/bilboed/buildbot/macosx-10.5-core/osx10.5-core-fast/../slave.build/fast/include/gstreamer-0.10 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/libxml2 -Wall -Wdeclaration-after-statement -Werror -fno-strict-aliasing -g -D_REENTRANT -I/Users/bilboed/buildbot/macosx-10.5-core/osx10.5-base-fast/../slave.build/fast/include/gstreamer-0.10 -I/Users/bilboed/buildbot/macosx-10.5-core/osx10.5-core-fast/../slave.build/fast/include/gstreamer-0.10 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/libxml2 -D_REENTRANT -I/Users/bilboed/buildbot/macosx-10.5-core/osx10.5-core-fast/../slave.build/fast/include/gstreamer-0.10 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/libxml2 -MT libgstosxvideosink_la-osxvideosink.lo -MD -MP -MF .deps/libgstosxvideosink_la-osxvideosink.Tpo -c -o libgstosxvideosink_la-osxvideosink.lo `test -f 'osxvideosink.m' || echo './'`osxvideosink.m mkdir .libs gcc -DHAVE_CONFIG_H -I. -I../.. -g -O2 -I../../gst-libs -I../../gst-libs -D_REENTRANT -I/Users/bilboed/buildbot/macosx-10.5-core/osx10.5-core-fast/../slave.build/fast/include/gstreamer-0.10 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/libxml2 -Wall -Wdeclaration-after-statement -Werror -fno-strict-aliasing -g -D_REENTRANT -I/Users/bilboed/buildbot/macosx-10.5-core/osx10.5-base-fast/../slave.build/fast/include/gstreamer-0.10 -I/Users/bilboed/buildbot/macosx-10.5-core/osx10.5-core-fast/../slave.build/fast/include/gstreamer-0.10 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/libxml2 -D_REENTRANT -I/Users/bilboed/buildbot/macosx-10.5-core/osx10.5-core-fast/../slave.build/fast/include/gstreamer-0.10 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/libxml2 -MT libgstosxvideosink_la-osxvideosink.lo -MD -MP -MF .deps/libgstosxvideosink_la-osxvideosink.Tpo -c osxvideosink.m -fno-common -DPIC -o .libs/libgstosxvideosink_la-osxvideosink.o cc1obj: warnings being treated as errors osxvideosink.m: In function 'gst_osx_video_sink_osxwindow_new': osxvideosink.m:86: warning: unused variable 'viewdata' osxvideosink.m: In function 'gst_osx_video_sink_osxwindow_destroy': osxvideosink.m:124: warning: ISO C90 forbids mixed declarations and code osxvideosink.m: In function 'gst_osx_video_sink_change_state': osxvideosink.m:204: warning: enumeration value 'GST_STATE_CHANGE_PLAYING_TO_PAUSED' not handled in switch osxvideosink.m:204: warning: enumeration value 'GST_STATE_CHANGE_PAUSED_TO_READY' not handled in switch osxvideosink.m:204: warning: enumeration value 'GST_STATE_CHANGE_READY_TO_NULL' not handled in switch osxvideosink.m:222: warning: enumeration value 'GST_STATE_CHANGE_NULL_TO_READY' not handled in switch osxvideosink.m:222: warning: enumeration value 'GST_STATE_CHANGE_READY_TO_PAUSED' not handled in switch osxvideosink.m:222: warning: enumeration value 'GST_STATE_CHANGE_PAUSED_TO_PLAYING' not handled in switch osxvideosink.m: In function 'gst_osx_video_sink_show_frame': osxvideosink.m:245: warning: pointer targets in assignment differ in signedness make[3]: *** [libgstosxvideosink_la-osxvideosink.lo] Error 1 make[2]: *** [all-recursive] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 program finished with exit code 2
Created attachment 128286 [details] [review] Fix build issues
Patch looks fine to me (but we're in freeze: need RM approval). It is awesome that gcc complains about ISO C90 features in a file which... isn't C at all.
OK with me. Any warnings are probably our fault, for supplying extra warnings args we should be (like the C++ case)
commit 309c651286946e6ddb24f8d8fa160a423ae6f4f3 Author: Edward Hervey <bilboed@bilboed.com> Date: Tue Feb 10 08:43:59 2009 +0100 osxvideosink: Fix build. Fixes #571038