GNOME Bugzilla – Bug 570532
(ARIA) Alert text not brailled when navigating it
Last modified: 2009-02-06 02:08:12 UTC
Go to http://codetalks.org/source/widgets/alert/alert.html For the sake of simplicity, bring up the last alert on the page. Arrow the caret up and down in the text of the alert. Orca speaks each line as you navigate between them, but only brailles "Alert".
I'll take a look at this one.
This seems to be another variant on bug 570524. Namely isNavigableAria is returning False (which means that Gecko shouldn't be handling it and it should be passed along to the default script). Adding a check for ROLE_ALERT solves the problem. I'll add a patch after I go through some more of these bugs you filed today and run the regression tests on the sum of all my patches. Stay tuned!
Created attachment 127990 [details] [review] revision 1 Pylinted and regression tested and seems to solve the reported issue. Will please review. If you're happy with it, I'll write a regression test corresponding to this bug. Thanks!
(In reply to comment #3) > Created an attachment (id=127990) [edit] > revision 1 > > Pylinted and regression tested and seems to solve the reported issue. Will > please review. If you're happy with it, I'll write a regression test > corresponding to this bug. Thanks! Nice! Thanks for tracking this one down. Instead of adding the ROLE_ALERT check as an extra elif statement, did you consider adding it to the ROLE_ENTRY, ROLE_LINK list? The only concern there is that we may potentially see a ROLE_ALERT in a COMBO_BOX some time.
Created attachment 128067 [details] [review] revision 2 (In reply to comment #4) > Nice! Thanks for tracking this one down. Instead of adding the ROLE_ALERT > check as an extra elif statement, did you consider adding it to the ROLE_ENTRY, > ROLE_LINK list? Well, yeah, I did. And then I thought, "Who on earth would put an alert inside of a combo box?" But now that you mention it.... ;-) This patch makes your suggested change and adds a regression test. Thanks! Patch committed to both trunk and the gnome-2-24 branch. Closing as FIXED.