After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570330 - seahorse fails to build outside source tree
seahorse fails to build outside source tree
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other Linux
: Normal minor
: 2.26.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks: 569778
 
 
Reported: 2009-02-03 09:21 UTC by Theppitak Karoonboonyanan
Modified: 2009-02-03 14:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
The fix (999 bytes, patch)
2009-02-03 09:24 UTC, Theppitak Karoonboonyanan 		none Details | Review
The fix (999 bytes, patch)
2009-02-03 09:27 UTC, Theppitak Karoonboonyanan 		accepted-commit_now Details | Review

Description Theppitak Karoonboonyanan 2009-02-03 09:21:59 UTC 
When building seahorse outside source tree, the following errors were found:

- In daemon/, build fails due to missing seahorse-service.xml:

---8<---
make[2]: Entering directory `/home/thep/build/gnome_svn/seahorse/daemon'
dbus-binding-tool --prefix=seahorse_service --mode=glib-server --output=seahorse-service-bindings.h /home/thep/vcs/gnome_svn/seahorse/daemon//home/thep/vcs/gnome_svn/seahorse/daemon/seahorse-service.xml
Couldn't stat /home/thep/vcs/gnome_svn/seahorse/daemon//home/thep/vcs/gnome_svn/seahorse/daemon/seahorse-service.xml: No such file or directory
make[2]: *** [seahorse-service-bindings.h] Error 1
make[2]: Leaving directory `/home/thep/build/gnome_svn/seahorse/daemon'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/thep/build/gnome_svn/seahorse'
make: *** [all] Error 2
---8<---

The path to seahorse-service.xml is duplicated twice.
Comment 1 Theppitak Karoonboonyanan 2009-02-03 09:24:32 UTC 
Created attachment 127819 [details] [review]
The fix

This patch works for me.

The "$<" in generic rules already represent the path to the source file. No need for another $(srcdir)/ in front of it.
Comment 2 Theppitak Karoonboonyanan 2009-02-03 09:27:57 UTC 
Created attachment 127821 [details] [review]
The fix

This patch works for me.

The "$<" in generic rules already represent the path to the source file. No need for another $(srcdir)/ in front of it.
Comment 3 Stef Walter 2009-02-03 14:35:56 UTC 
Looks good. Please commit with a ChangeLog.
Comment 4 Theppitak Karoonboonyanan 2009-02-03 14:43:59 UTC 
2009-02-03  Theppitak Karoonboonyanan  <thep@linux.thai.net>

        * daemon/Makefile.am: Remove excessive $(srcdir) in rules, fixing
        non-source-dir build error.  Fixes bug #570330.