After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569955 - fails to build from outside source tree
fails to build from outside source tree
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
2.25.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 569778
 
 
Reported: 2009-01-31 09:29 UTC by Theppitak Karoonboonyanan
Modified: 2009-01-31 13:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Replace $(top_builddir) with $(top_srcdir) (1.25 KB, patch)
2009-01-31 09:31 UTC, Theppitak Karoonboonyanan 		accepted-commit_now Details | Review

Description Theppitak Karoonboonyanan 2009-01-31 09:29:23 UTC 
When building gnome-settings-daemon from outside source tree, an error was found under plugins/media-keys/ subdir:

---8<---
/home/thep/vcs/gnome_svn/gnome-settings-daemon/plugins/media-keys/gsd-media-keys-manager.c:54:31: error: gvc-mixer-control.h: No such file or directory
---8<---

This is because "-I$(top_builddir)/plugins/media-keys/cut-n-paste", instead of $(top_srcdir)-rooted one, was supplied as CPPFLAGS in plugins/media-keys/Makefile.am. In $(top_builddir)/plugins/media-keys/cut-n-paste/, there was no any generated header file for use. So, the real intention here should be $(top_srcdir) instead.
Comment 1 Theppitak Karoonboonyanan 2009-01-31 09:31:01 UTC 
Created attachment 127614 [details] [review]
Replace $(top_builddir) with $(top_srcdir)

With this patch, g-s-d can be built off source-dir in my machine.
Comment 2 Jens Granseuer 2009-01-31 11:47:49 UTC 
Thanks, please commit.
Comment 3 Theppitak Karoonboonyanan 2009-01-31 13:12:55 UTC 
2009-01-31  Theppitak Karoonboonyanan  <thep@linux.thai.net>

        * plugins/media-keys/Makefile.am:  Fix include paths for
        non-source-dir builds.  (bug #569955)