After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569760 - Implement checks for current state before changing state in gdm-session-worker
Implement checks for current state before changing state in gdm-session-worker
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.25.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-30 04:02 UTC by Vincent Untz
Modified: 2009-07-17 19:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only change state if the current state is consistent with the action (5.19 KB, patch)
2009-01-30 04:02 UTC, Vincent Untz 		none Details | Review

Description Vincent Untz 2009-01-30 04:02:20 UTC 
It seems the patch I attached in bug 568323 can lead gdm-session-worker to have the setup phase done twice, with the second one called too late (while it's already in another state).

There are FIXME for that in the code, so I just went ahead and filled the hole. It seems to work okay here.
Comment 1 Vincent Untz 2009-01-30 04:02:55 UTC 
Created attachment 127509 [details] [review]
Only change state if the current state is consistent with the action
Comment 2 Ray Strode [halfline] 2009-07-17 19:40:31 UTC 
Thanks.