After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569725 - objects/SISSI/sissi_object.c:280: free() called for nothing
objects/SISSI/sissi_object.c:280: free() called for nothing
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: general
devel
Other All
: Normal minor
: 0.97
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-29 20:56 UTC by aggro
Modified: 2009-01-30 17:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description aggro 2009-01-29 20:56:22 UTC
In file objects/SISSI/sissi_object.c:280: free() is called for nothing.

In lines that don't affect filename in any way are removed, we see that free() is called for filename, even we know that filename is NULL. 

  gchar *filename = NULL;
  free (filename);

Redundant call for free() should be removed.
Comment 1 Hans Breuer 2009-01-30 17:45:43 UTC
2009-01-30  Hans Breuer  <hans@breuer.org>

	* objects/SISSI/area.c objects/SISSI/faraday.c objects/SISSI/room.c
	  objects/SISSI/sissi_object.c objects/SISSI/site.c : quite some 
	allocation/deallocation mismatch removed, fixes bug #569725