After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568885 - don't rely on gtk implementation details
don't rely on gtk implementation details
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks: 568886
 
 
Reported: 2009-01-23 17:44 UTC by Christian Persch
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Persch 2009-01-23 17:44:23 UTC
./src/interface.cpp:	action = static_cast<GtkAction*>(g_object_get_data (G_OBJECT (proxy),  "gtk-action"));

+++ This bug was initially created as a clone of Bug #568848 +++

While testing some GtkAction changes in GTK+ trunk, I've found that epiphany uses
g_object_get_data (widget, "gtk-action") to get at the action associated with a widget in some places. 

Please don't do that. We consider that undocumented object data an implementation detail, and it will go away at some point. Instead, use the documented api  for this: gtk_widget_get_action.
Comment 1 Benoît Dejean 2009-01-24 10:52:50 UTC
Hello Christian, do you think this also needs to be included in current stable gnome-2-24 ?
Comment 3 Christian Persch 2009-01-24 16:07:35 UTC
Not sure it's worth it on 2-24, since there'll be no more Gnome 2.24.x releases; for how long the workaround will be kept in gtk+ itself, see bug 568848 comment 10 and 11.
Comment 4 Chris Kühl 2011-02-24 11:35:42 UTC
This seems to have been fixed. Closing.