After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568768 - Orca starts at the top of a newly-loaded page rather than the specified fragment
Orca starts at the top of a newly-loaded page rather than the specified fragment
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.25.x
Other All
: Normal normal
: 2.24.4
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-01-22 21:57 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-02-13 20:39 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
revision 1 (5.23 KB, patch)
2009-02-02 22:51 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-01-22 21:57:12 UTC
Steps to reproduce:

1. Launch FF3 to a blank page

2. Press Control + L and enter the following URL: http://live.gnome.org/Orca#head-57a68c24cf7c113345e8389db746bfe158e464ba

3. Press Return

Expected results: Orca would set the caret context to the object specified by the fragment ("About Orca" heading) and present it.

Actual results: Orca sets the caret context to the top of the page and presents that instead.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-01-22 21:59:11 UTC
*Tentatively* targeting for 2.24.4 so that it's higher up on the list. A quick look at my debug.out taken while performing the above steps hints that we're not getting the appropriate caret-moved event, but I need to investigate further.
Comment 2 Joanmarie Diggs (IRC: joanie) 2009-02-02 22:51:35 UTC
Created attachment 127798 [details] [review]
revision 1

Will please review. Thanks!
Comment 3 Willie Walker 2009-02-03 14:48:40 UTC
(In reply to comment #2)
> Created an attachment (id=127798) [edit]
> revision 1
> 
> Will please review. Thanks!

It *seems* to look good to me, and it seems like it might provide a potential performance improvement.  It's kind of in a high traffic area of the code, though, so I'd feel more confident if people were able to give this a test before checking it in.  Thanks for your work!
Comment 4 Mesar Hameed 2009-02-03 15:19:44 UTC
Works very well for me. Thanks Joanie.
Comment 5 Joanmarie Diggs (IRC: joanie) 2009-02-03 21:16:14 UTC
Yea! Thanks Jon! As Will stated, the change I made touches quite a bit of what we do in the Gecko script. Therefore, I'd ask that you (and others) just keep using this patch for a bit to make sure there are no unwanted side effects.
Comment 6 Mike Pedersen 2009-02-04 22:48:58 UTC
So far I'm not noticing any problems with this patch.  
Comment 7 Joanmarie Diggs (IRC: joanie) 2009-02-10 21:26:35 UTC
I've committed the patch to trunk. Moving to pending while it gets some more testing before I commit it to the gnome-2-24 branch.
Comment 8 Mike Pedersen 2009-02-13 19:59:22 UTC
This one looks good.  
Comment 9 Joanmarie Diggs (IRC: joanie) 2009-02-13 20:39:15 UTC
Thanks Mike. Patch committed to the gnome-2-24 branch. Closing as FIXED.