After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568680 - Scanner misses fields (at least in GObject.Object)
Scanner misses fields (at least in GObject.Object)
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
: 569408 (view as bug list)
Depends on: 563469
Blocks:
 
 
Reported: 2009-01-22 12:02 UTC by Andreas Rottmann
Modified: 2015-02-07 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds offset test for a GObject-derived instance (1.47 KB, patch)
2009-01-22 12:08 UTC, Andreas Rottmann
none Details | Review
Fixes the loss of fields in GObjects (5.10 KB, patch)
2009-01-23 10:55 UTC, Andreas Rottmann
none Details | Review
v2 (7.17 KB, patch)
2009-01-28 02:17 UTC, Andreas Rottmann
none Details | Review

Description Andreas Rottmann 2009-01-22 12:02:56 UTC
For some reason, the scanner misses all fields of the GObject struct -- there are no <field> children of the <class> element for GObject in the GIR. This of course yields wrong field offsets for all derived objects.

I'll attach a patch that adds a testcase which exposes the bug.
Comment 1 Andreas Rottmann 2009-01-22 12:08:39 UTC
Created attachment 126989 [details] [review]
Adds offset test for a GObject-derived instance
Comment 2 Andreas Rottmann 2009-01-23 10:55:41 UTC
Created attachment 127079 [details] [review]
Fixes the loss of fields in GObjects
Comment 3 Johan (not receiving bugmail) Dahlin 2009-01-23 12:05:26 UTC
For the scanner part, can you please add a .xpath file that checks that the tags for the GObject fields are present? We really want to avoid this kind of regressions in the future.
Comment 4 Colin Walters 2009-01-28 02:14:56 UTC
*** Bug 569408 has been marked as a duplicate of this bug. ***
Comment 5 Andreas Rottmann 2009-01-28 02:17:01 UTC
Created attachment 127371 [details] [review]
v2

This patch now has xpath assertations, and also contains a fix for 569408, due to Colin Walters.
Comment 6 Colin Walters 2009-02-02 16:33:16 UTC
Applied, thanks!
Comment 7 André Klapper 2015-02-07 16:44:08 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]