GNOME Bugzilla – Bug 568490
gmmproc: gtk_accel_map_*() not substituted in documentation.
Last modified: 2009-04-25 10:20:02 UTC
I found in the description of function Gtk::Widget::set_accel_path(...) and Gtk::Widget::add_accelerator(...) inconsistencies making reference at gtk_accel_map_* but it should say functions defined in Gtk::AccelMap namespace.
you may found similar bugs in other classes, methods that make reference to Gtk::AccelMap
Yes, this is a general problem with gtk_accel_map*(). I have tried even hacking the substitution into glibmm/tools/pm/DocsParser.pm:substitute_function() but can't get it to work. I suspect that Daniel will see the problem more quickly.
A link to an example of the problem: http://www.gtkmm.org/docs/gtkmm-2.4/docs/reference/html/classGtk_1_1MenuItem.html#ab05629dd1ed0bb52b3efaf197e5b675
Created attachment 133169 [details] [review] Patch to add special case for non-object methods This patch adds several special cases for gtk methods that have no associated object in the .defs files. This fixes most of the bugs mentioned. It is not the greatest solution ever but it works for now.
Yes, that seems pragmatic. However, I doubt that this one is usfeful: "gtk_text_iter" => "TextIter" because we generally mention TextBuffer::iterator instead of TextIter, and the C++ API is quite different, so any methods might be guessed wrong. Otherwise, please commit, with a one-line description (for git) at the start of the ChangeLog entry.
Removed gtk_text_iter and changed the regular expressions as danielk suggested. There is a ChangeLog entry but I found now way to put this in a single git commit - sorry.
Please avoid pushing all your local commits to master. We only need to see the finished change. You can "squash" local git commits together. I forget how.