After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568386 - G_OBJECT is not need for g_signal_connect.
G_OBJECT is not need for g_signal_connect.
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-20 05:29 UTC by Hiroyuki Ikezoe
Modified: 2009-01-20 23:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (12.74 KB, patch)
2009-01-20 05:29 UTC, Hiroyuki Ikezoe 		committed Details | Review

Description Hiroyuki Ikezoe 2009-01-20 05:29:26 UTC 
G_OBJECT does not need for g_signal_connect.

The first argument of g_signal_connect is a gpointer so G_OBJECT is not need.
Comment 1 Hiroyuki Ikezoe 2009-01-20 05:29:54 UTC 
Created attachment 126820 [details] [review]
Proposed patch
Comment 2 Nickolay V. Shmyrev 2009-01-20 06:46:37 UTC 
Well, this provides additional protection by checking that the pointer is really gobject. Are there any arguments why dropping this check is better?
Comment 3 Hiroyuki Ikezoe 2009-01-20 22:29:53 UTC 
IMHO, G_TYPE_CHECK_INSTANCE in g_signal_connect_data is sufficient to check it.
Comment 4 Nickolay V. Shmyrev 2009-01-20 22:36:16 UTC 
Ok, can you commit please?
Comment 5 Hiroyuki Ikezoe 2009-01-20 23:05:44 UTC 
Done.

2009-01-21  Hiroyuki Ikezoe  <poincare@ikezoe.net>

        * shell/ev-sidebar-links.c
        * shell/ev-print-operation.c:
        * shell/ev-history.c:
        * shell/ev-file-monitor.c:
        * shell/ev-window.c:
        * shell/ev-password-view.c:
        * shell/ev-sidebar-thumbnails.c:
        * shell/ev-sidebar-attachments.c:
        * libview/ev-pixbuf-cache.c:
        * libview/ev-view.c: Remove needless G_OBJECT from g_signal_connect.
        Bug #568386.