After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567279 - Totem does not allow setting color balance settings to min or max
Totem does not allow setting color balance settings to min or max
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-01-10 16:50 UTC by Anssi Hannula
Modified: 2009-01-13 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Allow setting video properties to max and min values (1.08 KB, patch)
2009-01-10 16:51 UTC, Anssi Hannula 		committed Details | Review

Description Anssi Hannula 2009-01-10 16:50:27 UTC 
When setting color balance settings (brightness, contrast, etc), Totem does not
allow setting them to the Min/Max values. This affects both gst and xine
frontends and can be confirmed e.g. with xvinfo.

In addition this causes the issue that when starting up totem, and one of the
attributes is already set to min/max and there are no saved values, the attribute is reset to the middle value (which totem currently assumes to be the default, and is wrong for at least XV_HUE with NVIDIA cards, see bug #306621). 

The issue is a simple error in range check (< vs <=), patch attached.
Comment 1 Anssi Hannula 2009-01-10 16:51:07 UTC 
Created attachment 126177 [details] [review]
Allow setting video properties to max and min values
Comment 2 Bastien Nocera 2009-01-13 11:38:09 UTC 
2009-01-13  Bastien Nocera  <hadess@hadess.net>

        * src/backend/bacon-video-widget-gst-0.10.c
        (bacon_video_widget_set_video_property):
        * src/backend/bacon-video-widget-xine.c
        (bacon_video_widget_set_video_property): Patch from
        Anssi Hannula <anssi@mandriva.org> to avoid
        reseting the colour balance sliders when they're
        at the maximum or minimum (Closes: #567279)