After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 566180 - Orca inappropriately announces the name and role of (un)ordered list items as part of the context in Firefox 3.2
Orca inappropriately announces the name and role of (un)ordered list items as...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.25.x
Other All
: Normal normal
: 2.24.3
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-01-01 00:53 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-01-05 19:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
fix for the issue (1.14 KB, patch)
2009-01-01 01:14 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-01-01 00:53:50 UTC
Beginning with Firefox 3.2, items within an (un)ordered list have names which reflect the text they are displaying. In prior versions of Firefox, they didn't have names. As a result, when we get the speech context in 3.0 or 3.1, getDisplayedText returns nothing for parent list items and those items are not included in the context. In 3.2, however, we are unnecessarily chatty. It also screws up the reproducibility of our budding new multi-version regression tests. ;-)

Example: when a user Tabs amongst links which happen to be the contents of a bulleted list.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-01-01 01:14:45 UTC
Created attachment 125588 [details] [review]
fix for the issue

Yet another 1-liner (not counting 5 lines of comments I wanted to add to explain why we're doing this). 

Explicitly taking the list item out of the speech context in the Gecko script's speech generator (rather than allowing this to happen as a side effect) causes 3.0, 3.1, *and* 3.2 to all behave in the same, as-expected fashion.

No regression tests were harmed (or modified) in the creation of this patch. But this patch has been regression tested using Firefox 3.0.5, Firefox 3.1beta2, and the current Firefox 3.2 built from source. And it's been pylinted, of course.

As a result, I've committed this patch to trunk. And we are another step closer to a single set of pretty darned thorough regression tests which are reproducible in spite of the version differences.
Comment 2 Willie Walker 2009-01-05 13:41:09 UTC
This seems safe and appropriate for gnome-2-24 as well.  Joanie -- if you agree, please check it into gnome-2-24.
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-01-05 19:16:50 UTC
Done. Readjusting the milestone.